Move ECDHE key init to OpenSSL server context #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For client sockets it restricts what curves are available, making some TLS handshakes fail needlessly
|
Can we spec this? Possibly by connecting to |
|
I'm not sure, we would need a server that is configured to break with the previous behavior, which we currently have no real way to do that I'm aware of. In any case we won't make the spec situation worse without (there's zero specs covering any side of this) and writing that stuff would be 20 times the effort of figuring out this issue... |
|
<3 thanks |
|
@bcardiff do we want to cherry-pick this into the 0.24.2 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For client sockets it restricts what curves are available,
making some TLS handshakes fail needlessly
I mistakenly enabled this for client sockets in 6e43837