Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash_extender: init at 2017-04-10 #33253

Merged
merged 1 commit into from Feb 17, 2018
Merged

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Dec 31, 2017

Motivation for this change

This PR adds the hash_extender software to the nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@oxzi
Copy link
Member Author

oxzi commented Jan 28, 2018

Some updates on this one? Can this PR be merged? Has been open for round about a month.

@fpletz
Copy link
Member

fpletz commented Jan 28, 2018

@GrahamcOfBorg build hash_extender

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on aarch64-linux (full log)

Partial log (click to expand)

[LD] hash_extender_test
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/w1fjvjkc2z72kc8jfxmq2vnnn79hjdfv-hash_extender-2017-04-10
shrinking /nix/store/w1fjvjkc2z72kc8jfxmq2vnnn79hjdfv-hash_extender-2017-04-10/bin/hash_extender
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w1fjvjkc2z72kc8jfxmq2vnnn79hjdfv-hash_extender-2017-04-10/bin
patching script interpreter paths in /nix/store/w1fjvjkc2z72kc8jfxmq2vnnn79hjdfv-hash_extender-2017-04-10
checking for references to /build in /nix/store/w1fjvjkc2z72kc8jfxmq2vnnn79hjdfv-hash_extender-2017-04-10...
/nix/store/w1fjvjkc2z72kc8jfxmq2vnnn79hjdfv-hash_extender-2017-04-10

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on x86_64-linux (full log)

Partial log (click to expand)

[LD] hash_extender_test
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mqnwzp9rc5pl8lz5xbxwcy6m3f5farmw-hash_extender-2017-04-10
shrinking /nix/store/mqnwzp9rc5pl8lz5xbxwcy6m3f5farmw-hash_extender-2017-04-10/bin/hash_extender
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mqnwzp9rc5pl8lz5xbxwcy6m3f5farmw-hash_extender-2017-04-10/bin 
patching script interpreter paths in /nix/store/mqnwzp9rc5pl8lz5xbxwcy6m3f5farmw-hash_extender-2017-04-10
checking for references to /tmp/nix-build-hash_extender-2017-04-10.drv-0 in /nix/store/mqnwzp9rc5pl8lz5xbxwcy6m3f5farmw-hash_extender-2017-04-10...
/nix/store/mqnwzp9rc5pl8lz5xbxwcy6m3f5farmw-hash_extender-2017-04-10

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure on x86_64-darwin (full log)

Partial log (click to expand)

patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash
[CC] formats.o
/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash: gcc: command not found
make: *** [Makefile:39: formats.o] Error 127
builder for '/nix/store/lphf0h5s1w778q4z0fvipgm4y8rqsv2a-hash_extender-2017-04-10.drv' failed with exit code 2
error: build of '/nix/store/lphf0h5s1w778q4z0fvipgm4y8rqsv2a-hash_extender-2017-04-10.drv' failed

@oxzi
Copy link
Member Author

oxzi commented Feb 8, 2018

Seems to work fine for Linux-based operating systems. Could this be merged?

@joachifm joachifm merged commit 1c7fa5b into NixOS:master Feb 17, 2018
@oxzi oxzi deleted the hash_extender-2017-04-10 branch March 6, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants