ttfautohint: 1.7 -> 1.8.1 #33294
ttfautohint: 1.7 -> 1.8.1 #33294
Conversation
| @@ -0,0 +1,11 @@ | |||
| --- a/configure 2017-12-29 01:10:59.201970193 +0100 | |||
| +++ b/configure 2017-12-29 01:10:40.161330131 +0100 | |||
There was a problem hiding this comment.
It's unfortunate that this patches configure rather than configure.ac from which the former was generated.
There was a problem hiding this comment.
Judging by the fact that ttfautohint configure.ac doesn't have qmake_version_sed at all, it's brought in by Autotools and this could be solved just by autoreconfing the package (i.e. regenerating configure script). Could you please try adding autoreconfHook to nativeBuildInputs?
(We should really autoreconf all Autotools packages).
There was a problem hiding this comment.
I tried that, but it does not work. (Also crashes with configure: error: Cannot detect Qt's version.)
| @@ -17,10 +17,12 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| buildInputs = [ freetype harfbuzz libiconv ] ++ lib.optional enableGUI qtbase; | |||
|
|
|||
| configureFlags = lib.optional (!enableGUI) "--with-qt=no"; | |||
| configureFlags = (if enableGUI then "--with-qt=${qtbase}/lib" else "--with-qt=no"); | |||
There was a problem hiding this comment.
Perhaps:
configureFlags = [ ''--with-qt=${if enableGUI then "${qtbase}/lib" else "no"}'' ];
|
They released a new version, I will update the package to use that. So, please not merge now! |
|
@yegortimoshenko updated to 1.8.1 and that also fixes the compilation with qt5.10 :) |
|
@GrahamcOfBorg build ttfautohint |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
linked by target "mariadbclient" in directory /tmp/nix-build-mariadb-connector-c-2.3.4.drv-0/mariadb-connector-c-2.3.4-src/libmariadb
linked by target "libmariadb" in directory /tmp/nix-build-mariadb-connector-c-2.3.4.drv-0/mariadb-connector-c-2.3.4-src/libmariadb
-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-mariadb-connector-c-2.3.4.drv-0/mariadb-connector-c-2.3.4-src/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-mariadb-connector-c-2.3.4.drv-0/mariadb-connector-c-2.3.4-src/build/CMakeFiles/CMakeError.log".
builder for ‘/nix/store/91q9srsmgza1x00r6khvj2i9lq2adwlw-mariadb-connector-c-2.3.4.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/39ph34dihy7iyhmzh8j665il5jmvqggs-qtbase-5.9.3.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/78asf7f9z24cn1rdfsjnbjlpci04l50k-ttfautohint-1.8.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/78asf7f9z24cn1rdfsjnbjlpci04l50k-ttfautohint-1.8.1.drv’ failed
There was a problem hiding this comment.
Success for system: x86_64-linux
shrinking /nix/store/yzrgknj8fw704l8y9i8cxd1igld5g3s9-ttfautohint-1.8.1/bin/ttfautohint
shrinking /nix/store/yzrgknj8fw704l8y9i8cxd1igld5g3s9-ttfautohint-1.8.1/bin/ttfautohintGUI
shrinking /nix/store/yzrgknj8fw704l8y9i8cxd1igld5g3s9-ttfautohint-1.8.1/lib/libttfautohint.so.1.0.0
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzrgknj8fw704l8y9i8cxd1igld5g3s9-ttfautohint-1.8.1/lib /nix/store/yzrgknj8fw704l8y9i8cxd1igld5g3s9-ttfautohint-1.8.1/bin
patching script interpreter paths in /nix/store/yzrgknj8fw704l8y9i8cxd1igld5g3s9-ttfautohint-1.8.1
checking for references to /tmp/nix-build-ttfautohint-1.8.1.drv-0 in /nix/store/yzrgknj8fw704l8y9i8cxd1igld5g3s9-ttfautohint-1.8.1...
postPatchMkspecs
postMoveQtStaticLibs
/nix/store/yzrgknj8fw704l8y9i8cxd1igld5g3s9-ttfautohint-1.8.1
There was a problem hiding this comment.
Success for system: aarch64-linux
shrinking /nix/store/f3ib9qf15van5zfd9fyysm3z7l33g25v-ttfautohint-1.8.1/bin/ttfautohintGUI
shrinking /nix/store/f3ib9qf15van5zfd9fyysm3z7l33g25v-ttfautohint-1.8.1/bin/ttfautohint
shrinking /nix/store/f3ib9qf15van5zfd9fyysm3z7l33g25v-ttfautohint-1.8.1/lib/libttfautohint.so.1.0.0
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/f3ib9qf15van5zfd9fyysm3z7l33g25v-ttfautohint-1.8.1/lib /nix/store/f3ib9qf15van5zfd9fyysm3z7l33g25v-ttfautohint-1.8.1/bin
patching script interpreter paths in /nix/store/f3ib9qf15van5zfd9fyysm3z7l33g25v-ttfautohint-1.8.1
checking for references to /build in /nix/store/f3ib9qf15van5zfd9fyysm3z7l33g25v-ttfautohint-1.8.1...
postPatchMkspecs
postMoveQtStaticLibs
/nix/store/f3ib9qf15van5zfd9fyysm3z7l33g25v-ttfautohint-1.8.1
|
|
||
| buildInputs = [ freetype harfbuzz libiconv ] ++ lib.optional enableGUI qtbase; | ||
|
|
||
| configureFlags = lib.optional (!enableGUI) "--with-qt=no"; | ||
| configureFlags = [ ''--with-qt=${if enableGUI then "${qtbase}/lib" else "no"}'' ]; |
There was a problem hiding this comment.
Is the change to configureFlags necessary?
There was a problem hiding this comment.
No I don't think so. Any problems with that change?
There was a problem hiding this comment.
No, but it looks suspicious.
I have little time to review at the moment, but I noticed this PR due to the darwin build failure, whereas I knew that ttfautohint GUI used to work on darwin. I understand that master is in the bad shape now, but in general I expect that PRs that fail to build on the declared platforms are not merged. I had to fix mysql.connector-c in b41e5ec and ttfautohint in d1204e6.
There was a problem hiding this comment.
Ohh sorry! I did not wanted to break stuff on Mac Os. I thought that the package failed before also :(
The problem is that I have no Mac Os and can not do any debuggin/fixing :/
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)