Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: configuration-ghc-8.0.x.nix: keep inline-c at 0.5.6.1 #33271

Merged
merged 1 commit into from Jan 2, 2018
Merged

haskell: configuration-ghc-8.0.x.nix: keep inline-c at 0.5.6.1 #33271

merged 1 commit into from Jan 2, 2018

Conversation

basvandijk
Copy link
Member

Motivation for this change

inline-c > 0.5.6.1 requires template-haskell >= 2.12 which is not available on ghc-8.0 so we keep inline-c at 0.5.6.1 and inline-c-cpp at 0.1.0.0.

@peti I know I shouldn't edit hackage-packages.nix so where should I place the inline-c_0_5_6_1 and inline-c-cpp_0_1_0_0 definitions?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@basvandijk basvandijk requested a review from peti as a code owner January 1, 2018 12:05
@peti
Copy link
Member

peti commented Jan 1, 2018

Where should I place the inline-c_0_5_6_1 and inline-c-cpp_0_1_0_0 definitions?

Add the appropriate versions to the extra-packages section in pkgs/development/haskell-modules/configuration-hackage2nix.yaml. Then these versions will appear in hackage-packages.nix the next time we merge the update branch (i.e. every couple of days).

@basvandijk
Copy link
Member Author

Ok thanks, I added the versions to configuration-hackage2nix.yaml.

I guess I can leave the additions in hackage-packages.nix because then this PR can be merged immediately without having to wait for the next generation.

@peti peti merged commit b1fd018 into NixOS:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvandijk @peti @GrahamcOfBorg