sambaMaster: init at 4.8_2017-12-25 #33256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test samba |
There was a problem hiding this comment.
Failure for system: x86_64-linux
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 27092 100 27092 0 0 27092 0 0:00:01 --:--:-- 0:00:01 45304
fetching path ‘/nix/store/lcz15kqnmm40pwjlnlclr8m2b6gncxag-nixos-test-driver’...
fetching path ‘/nix/store/5hx1kiwg3zp3is41pfyrq67bdrpym0bw-zstd-1.3.3’...
building path(s) ‘/nix/store/xv9xbqmlzxb0b3aai73m13iy0v36r8yg-append-initrd-secrets’
killing process 53947
killing process 53945
killing process 53946
error: a ‘aarch64-linux’ is required to build ‘/nix/store/5kvcmpvrm9bd27a8rniymiq0qir035c5-append-initrd-secrets.drv’, but I am a ‘x86_64-linux’
|
@lukeadams can you confirm that samba tests works after this PR? our @GrahamcOfBorg is having problems. |
|
@garbas I'm currently running this on my NAS without issue. |
added 5 commits
January 25, 2018 17:36
reason: Second hunk does not work on 4.8-master
|
Rebased onto 0f5f904, also bumped version. (2018-01-25) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Samba 4.8 releases around March 2018. sambaMaster may be useful for those who would like to test experimental macOS Time Machine support, which is what I'm using this for.
To use this on NixOS:
To enable TM for a share, add the following to the share definition:
Currently master piggybacks off of the 4.x definition with minimal modifications (overrideAttrs+override)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)