Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmon: init at 16g #33285

Closed
wants to merge 1 commit into from
Closed

nmon: init at 16g #33285

wants to merge 1 commit into from

Conversation

vquintin
Copy link

@vquintin vquintin commented Jan 1, 2018

Motivation for this change

This PR adds nmon to the nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 2, 2018

@grahamc build nmon

@joachifm
Copy link
Contributor

@GrahamcOfBorg build nmon

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

trying http://sourceforge.net/projects/nmon/files/lmon16g.c
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   178  100   178    0     0    438      0 --:--:-- --:--:-- --:--:--   437
100   307  100   307    0     0    271      0  0:00:01  0:00:01 --:--:--   271
100   381  100   381    0     0    285      0  0:00:01  0:00:01 --:--:--     0
100   295  100   295    0     0    142      0  0:00:02  0:00:02 --:--:--   142
100  261k  100  261k    0     0   111k      0  0:00:02  0:00:02 --:--:-- 2466k
building '/nix/store/i8c4pb6y3c24fx5wk818kv5ka311fnwi-nmon-16g.drv'...
/nix/store/ix130a6rnc1f74air28ralg6z672kdf1-nmon-16g

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

trying http://sourceforge.net/projects/nmon/files/lmon16g.c
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   178  100   178    0     0   1092      0 --:--:-- --:--:-- --:--:--  1085
100   307  100   307    0     0    600      0 --:--:-- --:--:-- --:--:--   600
100 15777  100 15777    0     0  22799      0 --:--:-- --:--:-- --:--:-- 22799
100   303  100   303    0     0    295      0  0:00:01  0:00:01 --:--:--     0
100  261k  100  261k    0     0   155k      0  0:00:01  0:00:01 --:--:--  155k
building '/nix/store/m7bxzxq5mpx7vwiyjn183q9dbjc55km0-nmon-16g.drv'...
/nix/store/iss9f186phnx8hxcskzh2aafxhg2q1qr-nmon-16g

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

100 15771  100 15771    0     0  10064      0  0:00:01  0:00:01 --:--:-- 10064
100   297  100   297    0     0    127      0  0:00:02  0:00:02 --:--:--   563
100  261k  100  261k    0     0   9694      0  0:00:27  0:00:27 --:--:-- 54484
building '/nix/store/6gqz78hz5bczmb27my9ql7n0zq0d6qq3-nmon-16g.drv'...
/nix/store/2a28ldy8km9z4c2gkxrqp6wgq0p1cjkr-lmon16g.c:578:10: fatal error: 'mntent.h' file not found
#include <mntent.h>
         ^~~~~~~~~~
1 error generated.
builder for '/nix/store/6gqz78hz5bczmb27my9ql7n0zq0d6qq3-nmon-16g.drv' failed with exit code 1
error: build of '/nix/store/6gqz78hz5bczmb27my9ql7n0zq0d6qq3-nmon-16g.drv' failed

joachifm
joachifm reviewed Feb 17, 2018
View reviewed changes
pkgs/os-specific/linux/nmon/builder.sh
@@ -0,0 +1,11 @@
source $stdenv/setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this is an old-school way of packaging; it's way more common to inline the builder in the Nix expression/rely on the standard build sequence. In this case, I think you can get away with setting buildPhase and installPhase (setting buildCommand could work too, but then you need more boilerplate).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have ancient documentation, which show examples like this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nice for understanding, but there should be a warning sign or something: https://github.com/NixOS/nixpkgs/blob/master/doc/stdenv.xml#L90

@sveitser
Copy link
Contributor

@vquintin I also prepared a derivation for nmon and later saw that this PR already existed. I think it would address @joachifm 's comments above.

https://github.com/NixOS/nixpkgs/compare/master...sveitser:nmon?expand=1

@Mic92
Copy link
Member

Mic92 commented Mar 31, 2018 •
edited

yes it would. You can open a pull request, if you want.

@sveitser sveitser mentioned this pull request Apr 1, 2018
Merged
8 tasks
@sveitser
Copy link
Contributor

sveitser commented Apr 1, 2018

@Mic92 opened #38283

@Mic92
Copy link
Member

Mic92 commented Apr 1, 2018

the other pull request was merged.

@Mic92 Mic92 closed this Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vquintin @Mic92 @joachifm @GrahamcOfBorg @sveitser @Janik-Haag