supercollider: added alsaLib as dependency, req. for MIDI on Linux #33262
Conversation
| @@ -1,6 +1,8 @@ | |||
| { stdenv, fetchurl, cmake, pkgconfig | |||
| , libjack2, libsndfile, fftw, curl, gcc | |||
| , libXt, qtbase, qttools, qtwebkit, readline | |||
| , withAlsa ? !stdenv.isDarwin, alsaLib # ALSA is required for MIDI to work in SC | |||
There was a problem hiding this comment.
There is no need for withAlsa: enable it for Linux unconditionally.
There was a problem hiding this comment.
I put in ALSA to be optional since it's indicated as optional in supercollider readme.
There was a problem hiding this comment.
Nevertheless, there is no use in making it optional in Nixpkgs.
| @@ -1,6 +1,8 @@ | |||
| { stdenv, fetchurl, cmake, pkgconfig | |||
| , libjack2, libsndfile, fftw, curl, gcc | |||
| , libXt, qtbase, qttools, qtwebkit, readline | |||
| , withAlsa ? !stdenv.isDarwin, alsaLib # ALSA is required for MIDI to work in SC | |||
| , withAvahi ? false, avahi # Avahai is optional dependency | |||
There was a problem hiding this comment.
qtbase already depends on avahi, no need to make it optional here.
There was a problem hiding this comment.
the cmake build system doesn't find avahi unless specifically added to dependencies
There was a problem hiding this comment.
Yes, please add it as a dependency, but remove withAvahi option.
| @@ -24,10 +26,12 @@ stdenv.mkDerivation rec { | |||
| -DSC_EL=${if useSCEL then "ON" else "OFF"} | |||
| ''; | |||
|
|
|||
| nativeBuildInputs = [ cmake pkgconfig qttools ]; | |||
| nativeBuildInputs = [cmake pkgconfig qttools ] | |||
incorporated the reviewer's comments
|
@orivej requested changes have been applied, please let me know if further changes are need. |
Motivation for this change
Currently
MIDIClient.initcommand in SC fails mysteriously on Linux. SC requires alsa at compile time to enable MIDI. This commit fixes that issue.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)