Qt5: 5.9.3 -> 5.10.0 #33297
Qt5: 5.9.3 -> 5.10.0 #33297
Conversation
There was a problem hiding this comment.
Failure for system: x86_64-darwin
/nix/store/cmgjkmgri309v29jxfdfzwzk8i79514y-apple-framework-Foundation/Library/Frameworks/Foundation.framework/Headers/NSPortCoder.h:18:1: warning: method has no return type specified; defaults to 'id' [-Wmissing-method-return-type]
+ portCoderWithReceivePort:(NSPort *)rcvPort sendPort:(NSPort *)sndPort components:(NSArray *)comps NS_DEPRECATED(10_0, 10_7, 2_0, NA);
^
(id)
qcorewlanengine.mm:290:5: error: type arguments cannot be applied to non-parameterized class 'NSArray'
NSArray<NSString *> *wifiInterfaces = [CWWiFiClient interfaceNames];
^ ~~~~~~~~~~~~
qcorewlanengine.mm:605:5: error: type arguments cannot be applied to non-parameterized class 'NSArray'
NSArray<NSString *> *wifiInterfaces = [CWWiFiClient interfaceNames];
^ ~~~~~~~~~~~~
4 warnings and 2 errors generated.
make[4]: *** [Makefile:2068: .obj/qcorewlanengine.o] Error 1
make[4]: Leaving directory '/private/tmp/nix-build-qtbase-5.10.0.drv-0/qtbase-everywhere-src-5.10.0/src/plugins/bearer/corewlan'
make[3]: *** [Makefile:46: sub-corewlan-make_first] Error 2
make[3]: Leaving directory '/private/tmp/nix-build-qtbase-5.10.0.drv-0/qtbase-everywhere-src-5.10.0/src/plugins/bearer'
make[2]: *** [Makefile:78: sub-bearer-make_first] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-qtbase-5.10.0.drv-0/qtbase-everywhere-src-5.10.0/src/plugins'
make[1]: *** [Makefile:722: sub-plugins-make_first] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-qtbase-5.10.0.drv-0/qtbase-everywhere-src-5.10.0/src'
make: *** [Makefile:49: sub-src-make_first] Error 2
|
When the Darwin build failure is fixed, I will merge this offline. I have an unmerged fix for a closure-size bug that will also apply here; I'll merge them together to avoid rebuilding the Qt-world twice. |
|
@LnL7 could you try again please? |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
In file included from /nix/store/6fx1x2fzsf03ddrf5lxm5n7f5nnj2jzn-apple-framework-AppKit/Library/Frameworks/AppKit.framework/Headers/AppKit.h:203:
/nix/store/6fx1x2fzsf03ddrf5lxm5n7f5nnj2jzn-apple-framework-AppKit/Library/Frameworks/AppKit.framework/Headers/NSPathComponentCell.h:42:27: warning: 'copy' attribute on property 'image' does not match the property inherited from 'NSCell' [-Wproperty-attribute-mismatch]
@property (copy) NSImage *image;
^
qcocoawindow.mm:1702:29: error: property 'superview' not found on object of type 'id'
[window.contentView.superview setNeedsDisplay:YES];
^
11 warnings and 1 error generated.
make[4]: *** [Makefile:7439: .obj/qcocoawindow.o] Error 1
make[4]: Leaving directory '/private/tmp/nix-build-qtbase-5.10.0.drv-0/qtbase-everywhere-src-5.10.0/src/plugins/platforms/cocoa'
make[3]: *** [Makefile:97: sub-cocoa-make_first] Error 2
make[3]: Leaving directory '/private/tmp/nix-build-qtbase-5.10.0.drv-0/qtbase-everywhere-src-5.10.0/src/plugins/platforms'
make[2]: *** [Makefile:103: sub-platforms-make_first] Error 2
make[2]: Leaving directory '/private/tmp/nix-build-qtbase-5.10.0.drv-0/qtbase-everywhere-src-5.10.0/src/plugins'
make[1]: *** [Makefile:722: sub-plugins-make_first] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-qtbase-5.10.0.drv-0/qtbase-everywhere-src-5.10.0/src'
make: *** [Makefile:49: sub-src-make_first] Error 2
builder for '/nix/store/qnmpbd6ahqq9pgc0nsb1l5dy639zfkap-qtbase-5.10.0.drv' failed with exit code 2
|
@bkchr This one looks like it might need some debugging, let me know if you want me to look at it. |
|
@LnL7 yeah, it would be nice if you could debug this error. |
|
@LnL7 any updates? :) |
|
Sorry, I've been pretty busy with other stuff. |
|
Okay. @ttuegel do you have any Mac OS? |
|
That fixes qtbase, still testing the rest. |
|
👍 |
|
@GrahamcOfBorg eval |
|
Does an extra qtXX set increase the memory usage by a significant amount? Other evaluations seem to be working fine right now. |
@bkchr No, I have only
@LnL7 It should not because there are not many packages. I think we should leave the default Qt 5 version at Qt 5.9.x for now. I have two reasons; one is that Qt 5.9 is an LTS branch, the other is that KDE is still shipping fixes for Qt 5.9 and I suspect Qt 5.10 is going to break things that upstream doesn't even know about yet. I want to re-evaluate this stance after Frameworks 5.42, though. |
|
@GrahamcOfBorg eval |
|
@ttuegel I saw posts that they already shipped the 5.10 beta for kde neon. |
|
@GrahamcOfBorg eval :/ |
|
From what I can tell this increases the memory usage by almost 200mb causing the evaluator to hit the default heapsize limit. |
Yes, but they haven't shipped any patches for Qt 5.10, which means it isn't ready. In fact, they just had to respin two packages in the Applications release today to patch for Qt 5.9.3, so they obviously aren't caught up yet.
There must be a bug in the package set; there is no way that adding O(10) packages should increase memory use that much! |
Hm, it's actually more like O(100) packages because of needing to build libraries with every version of Qt for compatibility. In the long term, I would like to take advantage of the Qt ABI to re-link everything against our latest Qt version; this would drastically cut down on the number of libraries there are to build. In the short term, I think I will just remove |
|
@GrahamcOfBorg eval |
|
@bkchr I'm working on merging this now. |
Supersedes: NixOS#33297
|
This broke |
|
Fixed in: #33927 |
|
There is a whole lot of other breakages too. @bkchr Could you take a look at these packages: |
|
@adisbladis I tested |
|
@bkchr I just greped for usage of |
|
Yep, I will look into them, when I got time :) |
|
Thanks 👍 |
Motivation for this change
I hope that I tackled all required extra packages in other pull requests. (
nox reviewis taking ages)@LnL7 can you try that on Mac?
@ttuegel
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)