Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test cases from an exclude list #4928

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Remove test cases from an exclude list #4928

merged 1 commit into from
Jan 2, 2018
+0 −9

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Jan 1, 2018

$SAFE level 2 was obsoleted on MRI 2.3.
So these test cases for ENV was dropped (r50958).

see: ruby/ruby@5d6ca9e

@yui-knk
Remove test cases from an exclude list
be76e73 
`$SAFE` level 2 was obsoleted on MRI 2.3.
So these test cases for `ENV` was dropped (r50958).

see: ruby/ruby@5d6ca9e
olleolleolle
olleolleolle approved these changes Jan 1, 2018
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clear cleanup change which makes sense. Thank you for including the link to the MRI commit.

@kares
Copy link
Member

kares commented Jan 1, 2018

interestingly the CI build seems completely broken on this PR

@olleolleolle
Copy link
Member

olleolleolle commented Jan 1, 2018 •
edited
Loading

@kares: "oci runtime error: exec failed: container_linux.go:265: starting container process caused "could not create session key: disk quota exceeded"" (like, in Travis starting the instance)

Can you "retry" it?

@kares
Copy link
Member

kares commented Jan 2, 2018

right it was CI - made no sense for these changes to cause a fatal build failure, tests do run after rebuild

     [exec] [2652/8763] TestEnumerator#test_yielder = 0.00 s
     [exec] [2653/8763] TestEnv#test_bracket = 0.01 s
     [exec] [2654/8763] TestEnv#test_clear = 0.00 s
     [exec] [2655/8763] TestEnv#test_delete_if = 0.00 s
     [exec] [2656/8763] TestEnv#test_each_key = 0.00 s
     [exec] [2657/8763] TestEnv#test_each_pair = 0.01 s
     [exec] [2658/8763] TestEnv#test_each_value = 0.00 s
     [exec] [2659/8763] TestEnv#test_empty_p = 0.00 s
     [exec] [2660/8763] TestEnv#test_frozen = 0.02 s
     [exec] [2661/8763] TestEnv#test_has_value = 0.00 s
     [exec] [2662/8763] TestEnv#test_has_value2 = 0.00 s
     [exec] [2663/8763] TestEnv#test_huge_value = 0.01 s
     [exec] [2664/8763] TestEnv#test_inspect = 0.00 s
     [exec] [2665/8763] TestEnv#test_invert = 0.00 s
     [exec] [2666/8763] TestEnv#test_keep_if = 0.00 s
     [exec] [2667/8763] TestEnv#test_key = 0.00 s
     [exec] [2668/8763] TestEnv#test_keys = 0.00 s
     [exec] [2669/8763] TestEnv#test_rassoc = 0.00 s
     [exec] [2670/8763] TestEnv#test_reject = 0.00 s
     [exec] [2671/8763] TestEnv#test_reject_bang = 0.00 s
     [exec] [2672/8763] TestEnv#test_replace = 0.00 s
     [exec] [2673/8763] TestEnv#test_select = 0.00 s
     [exec] [2674/8763] TestEnv#test_select_bang = 0.00 s
     [exec] [2675/8763] TestEnv#test_shared_substring = 0.00 s
     [exec] [2676/8763] TestEnv#test_shift = 0.00 s
     [exec] [2677/8763] TestEnv#test_size = 0.00 s
     [exec] [2678/8763] TestEnv#test_to_a = 0.00 s
     [exec] [2679/8763] TestEnv#test_to_h = 0.00 s
     [exec] [2680/8763] TestEnv#test_to_hash = 0.00 s
     [exec] [2681/8763] TestEnv#test_to_s = 0.00 s
     [exec] [2682/8763] TestEnv#test_update = 0.00 s
     [exec] [2683/8763] TestEnv#test_values = 0.00 s
     [exec] [2684/8763] TestEnv#test_values_at = 0.00 s
     [exec] [2685/8763] TestEtc#test_getgrgid = 0.03 s

@kares kares merged commit ec3f91d into jruby:master Jan 2, 2018
@kares kares added this to the Non-Release milestone Jan 2, 2018
@kares kares added the tests label Jan 2, 2018
@yui-knk yui-knk deleted the remove_safe_level2_tests branch January 2, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
Non-Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yui-knk @kares @olleolleolle