Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckb: 0.2.8 -> 2018-01-01 #33286

Closed
wants to merge 1 commit into from
Closed

ckb: 0.2.8 -> 2018-01-01 #33286

wants to merge 1 commit into from

Conversation

Nadrieril
Copy link
Member

Motivation for this change

The upstream package has not had a release since May 2017, but the master branch has had a lot of updates since, including support for new devices. I therefore thought it made sense to update the nixos package to the latest master commit.
I don't know if this is common practise though, so if we'd rather follow releases I could as easily make a ckb-unstable package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

bjornfor commented Jan 1, 2018

IMHO, it's much better for end users if upstream makes a new release. So personally I'd spend my energy on helping upstream (or applying gentle pressure) rather than creating separate nixpkgs package and/or updating to unreleased software.

@kierdavis
Copy link
Contributor

Thanks for taking the initiative with this. I agree with @bjornfor in regard to sticking with stable releases only for the ckb-next package. However the project's mailing list suggests that the project owner has been unreachable for a few months, which might be blocking package releases. Creating a ckb-next-unstable package may be a good option here.

@Nadrieril
Copy link
Member Author

The project seems to have been taken over, so this is not relevant anymore.

@Nadrieril Nadrieril closed this Jan 22, 2018
@Nadrieril Nadrieril mentioned this pull request Jan 22, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Nadrieril @bjornfor @kierdavis @GrahamcOfBorg