Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hakuneko: mark as broken #33264

Merged
merged 1 commit into from Jan 1, 2018
Merged

Conversation

RubenAstudillo
Copy link
Contributor

This project was abandoned upstream in favor a new project based on
electron. This version builds yet the code doesn't work with most
providers, so it is practically broken.

Motivation for this change

Code was deprecated. Maybe it will signal that help for the electron based
project is needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This project was abandoned upstream in favor a new project based on
electron. This version builds yet the code doesn't work with most
providers, so it is practically broken.
@teto
Copy link
Member

teto commented Jan 1, 2018

I can confirm, I had to install the new one on windows, I hope the nix package can get updated too.

@RubenAstudillo
Copy link
Contributor Author

Yep. The thing is I don't even know how to ship an electron app. I hope this will signal interest on somebody to put the effort (I am also reading about it).

@FRidh FRidh merged commit 7a0938c into NixOS:master Jan 1, 2018
@RubenAstudillo RubenAstudillo deleted the hakuneko-broken branch October 21, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants