john: Fix extra utility programs #33257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
john
package includes a number of extra utilities, mostly of the form "x2john" where "x" is some password file format. These are written either in python, perl, or included in the "john" executable and available when called through a symlink.This commit (mostly) fixes these utilities. Previously, the symlinks were not included, and the perl/python scripts wouldn't run since they didn't have correct shebang lines or dependencies. This should correct that.
One important note is that some utilities have versions written in multiple languages (for whatever reason). For example, aix2john.pl and aix2john.py, as well as dmg2john and dmg2john.py. The previous build script would strip off the .{pl,py} extension of python and perl scripts, which would clobber these identically named utilities. I've left the .{pl,py} extensions as-is in my commit.
Finally, I've left a TODO in for a couple of utilities (radius2john.pl and lion2john-alt.pl) that are still not working, because their dependencies are not packaged in nixpkgs.
CC @offline
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)