Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-1.8, go-1.9: use stdenv.shell instead of /usr/bin/env bash #33279

Merged
merged 1 commit into from
Jan 2, 2018
Merged

go-1.8, go-1.9: use stdenv.shell instead of /usr/bin/env bash #33279

merged 1 commit into from
Jan 2, 2018
+2 −2

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

On ARM, the go 1.8 and 1.9 have a reference to /usr/bin/env bash which breaks sandbox builds. This PR changes this reference to ${stdenv.shell}.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@lopsided98
go-1.8, go-1.9: use stdenv.shell instead of /usr/bin/env bash

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
23ffb9d 
Fixes tests on ARMv6/7 during sandboxed builds.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 1, 2018
@Mic92 Mic92 merged commit bc5bf95 into NixOS:master Jan 2, 2018
@lopsided98 lopsided98 deleted the go-stdenv-shell branch January 6, 2018 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @Mic92 @GrahamcOfBorg