Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkypeExport: init at 1.4.0 #32694

Merged
merged 1 commit into from Dec 23, 2017
Merged

SkypeExport: init at 1.4.0 #32694

merged 1 commit into from Dec 23, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Dec 15, 2017

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This may be controversial due to the fact that I use the same case in the attribute name (and the directory name) as the author uses in the executable's name and the project's name.

@rycee
Copy link
Member

rycee commented Dec 15, 2017

Thanks for the contribution!

This may be controversial due to the fact that I use the same case in the attribute name (and the directory name) as the author uses in the executable's name and the project's name.

I would suggest changing these names to "skype-export" instead which is closer to the naming guidelines.

@orivej
Copy link
Contributor

orivej commented Dec 15, 2017

I would suggest changing these names to "skype-export" instead which is closer to the naming guidelines.

No, even according to the linked section the options are SkypeExport and skypeexport.

@orivej
Copy link
Contributor

orivej commented Dec 15, 2017

I'd prefer skypeexport for the attribute in all packages (EDIT and directory name) and SkypeExport for name, following the convention used for VirtualBox.

@rycee
Copy link
Member

rycee commented Dec 15, 2017

@orivej But "skypeexport" would clash with the directory name:

Names of files and directories should be in lowercase, with dashes between words — not in camel case. For instance, it should be all-packages.nix, not allPackages.nix or AllPackages.nix.

I've taken this to apply also to the package names and have attempted to clarify the naming in #31668.

@orivej orivej merged commit e3d7e45 into NixOS:master Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants