Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liquibase-3.5.3 (update) adding PostgreSQL support #32688

Closed
wants to merge 3 commits into from

Conversation

nyarly
Copy link
Contributor

@nyarly nyarly commented Dec 15, 2017

No description provided.

Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested calling postgres from a liquibase specification?

It should be possible to create an automated test for postgresql, see https://gitlab.techcultivation.org/sangha/sangha-deployment/blob/master/containers/helpers/postgres-template.nix#L31 for an example on how to run postgres inside the build.
If you don’t want to invest the time, a manual test would be enough as well for now.

@@ -1,12 +1,14 @@
{ stdenv, fetchurl, writeText, jre, makeWrapper, fetchMavenArtifact
, mysqlSupport ? true, mysql_jdbc ? null }:
, mysqlSupport ? true, mysql_jdbc ? null
, postgresSupport ? true, postgresql_jdbc ? null }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rename to postgresqlSupport to keep the same naming.

@nyarly
Copy link
Contributor Author

nyarly commented Dec 15, 2017

@Profpatsch Do you have a liquibase changelog to work from? I've been trying to get this working for my own purposes (and if I can, I'll report it as manually tested), but as a result I don't have anything I can actually test with.

@Profpatsch
Copy link
Member

Do you have a liquibase changelog to work from?

No, sorry. I’m not sure I even did use liquibase back then. :)

@grahamc
Copy link
Member

grahamc commented Dec 17, 2017

@GrahamcOfBorg eval

@nyarly
Copy link
Contributor Author

nyarly commented Dec 18, 2017

This has been manually tested now. I'd like to puzzle out how to do the automated testing... time limits forbid at the moment.

postgresql_jdbc = callPackage ../servers/sql/postgresql/jdbc { };
postgresql_jdbc = callPackage ../servers/sql/postgresql/jdbc {
fetchMaven = callPackage ../development/java-modules/m2install.nix { };
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: should be dedented by two spaces.

@aanderse
Copy link
Member

@nyarly are you able to continue with this PR?

@Ekleog
Copy link
Member

Ekleog commented Jun 15, 2019

(triage) Closing for now due to lack of activity, @nyarly feel free to react if you want to continue working on this!

@Ekleog Ekleog closed this Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants