New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle exceptions from stoi #1736

Merged

edolstra merged 2 commits into NixOS:master from bgamari:stoi-exceptions

Dec 15, 2017

Contributor

bgamari commented Dec 15, 2017

I encountered an exception from stoi which I believe was from the JSON parser.

bgamari added 2 commits

December 14, 2017 19:09


          json-to-value: Throw sensible error message on invalid numbers

f9bcbdd


          edit: Catch stoi exceptions from line number parsing

626a94d

shlevy approved these changes

View reviewed changes

Member

shlevy commented Dec 15, 2017

@edolstra barring objections I'll merge early next week.

edolstra merged commit 1dffbff into NixOS:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment