Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

garcon: fix issues 10967, 12700 (Xfce) #32689

Merged
merged 1 commit into from Dec 16, 2017
Merged

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Dec 15, 2017

Motivation for this change

I've ran into some bugs with Xfce's application menu. 10967 is fixed in master, while 12700 is not committed (yet). I'm currently running a Xfce session that incorporates these patches.

https://bugzilla.xfce.org/show_bug.cgi?id=10967
https://bugzilla.xfce.org/show_bug.cgi?id=12700

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej merged commit 6d6ca9c into NixOS:master Dec 16, 2017
@lukateras lukateras deleted the garcon/fixes branch December 18, 2017 05:39
@lukateras lukateras added the 6.topic: xfce The Xfce Desktop Environment label Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants