chicken: 4.11.0 -> 4.13.0 #32679
Merged
chicken: 4.11.0 -> 4.13.0 #32679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was it necessary to refresh the patch? Normally we do not do it when the patch applies as is. |
|
Not necessary, but it applied with fuzz and it was simple enough to reproduce from 4.13.0, so I did. Shall I revert it? |
|
I would drop it from the PR because it is confusing, but this is not a requirement. (The previous update of the patch was significant: evhan@cd01aab .) |
Also update the chicken-ssql egg dependency version for ugarit and ugarit-manifest-maker from 0.2.2 to 0.2.4 to include a fix for an issue uncovered by chicken-4.13.0 (see [1] and [2] for more info). [1]: https://bitbucket.org/DerGuteMoritz/ssql/pull-requests/1 [2]: https://salmonella-linux-x86-64.call-cc.org/chicken-4/gcc/linux/x86-64/2017/04/19/yesterday-diff/log2/install/ssql.html
|
Done, cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://lists.nongnu.org/archive/html/chicken-announce/2017-12/msg00005.html
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)See commit message for details about the chicken-ssql version bump.