Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cassandra: 3.0.9 -> 3.11.1 #32702

Merged
merged 1 commit into from Dec 15, 2017
Merged

cassandra: 3.0.9 -> 3.11.1 #32702

merged 1 commit into from Dec 15, 2017

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Dec 15, 2017

Motivation for this change

Support for SASI index (>3.4)

Things done

Built and run for testing purposes

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@roberth
Copy link
Member

roberth commented Dec 15, 2017

Cassandra 3.0 continues to be supported until after the next major version (which is not planned), so I suggest we keep supporting it too. People often like a very stable database and the 3.0 series seems to be precisely that. I suggest keeping it and pointing the cassandra attribute at 3.15.

@nlewo
Copy link
Member Author

nlewo commented Dec 15, 2017

@roberth Ok, it sounds better. So. we keep cassandra = cassandra_3_0 and I add the attribute cassandra_3_11.
Is it ok?

@roberth
Copy link
Member

roberth commented Dec 15, 2017

Please amend your branch, so a maintainer can merge it if approved.

We still keep the 3.0.9 attribute to have a stable 3.x release.
@roberth
Copy link
Member

roberth commented Dec 15, 2017

lgtm, @nckx could you review and merge?

@nckx nckx merged commit dc33a09 into NixOS:master Dec 15, 2017
@nckx
Copy link
Member

nckx commented Dec 15, 2017

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants