Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 9.2.0 -> 9.3.0, libuv: 1.16.1 -> 1.18.0 #32686

Merged
merged 2 commits into from Dec 16, 2017
Merged

nodejs: 9.2.0 -> 9.3.0, libuv: 1.16.1 -> 1.18.0 #32686

merged 2 commits into from Dec 16, 2017

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Dec 14, 2017 •
edited

Motivation for this change

Making nodejs_9_x up-to-date.

Things done

nodejs 9.3.0 didn't compile using libuv 1.16.1, so I've also upgraded libuv. libuv has a lot of dependencies, which I haven't all build yet. A previous PR for nodejs 9 and libuv seemed to be building fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" (tried using nix-shell -p nox --run "nox-review wip --against upstream/master", but fails due to using Nix 1.12pre4911_b30d1e7). Manually tested the following:
    • neovim
    • nodejs_9_x
    • pixie
    • neovim
    • libwebsockets
    • cmake
    • ... others
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat vcunat changed the base branch from master to staging December 16, 2017 16:11
@vcunat vcunat merged commit aa86d13 into NixOS:staging Dec 16, 2017
vcunat added a commit that referenced this pull request Dec 16, 2017
@vcunat
Merge #32686: update nodejs and libuv
f7460f6
@bobvanderlinden bobvanderlinden deleted the nodejs_9_3_0 branch December 16, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @vcunat @GrahamcOfBorg