Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brotli: 0.6.0 -> 1.0.1 #32123

Merged
merged 5 commits into from Nov 29, 2017
Merged

brotli: 0.6.0 -> 1.0.1 #32123

merged 5 commits into from Nov 29, 2017

Conversation

kosta
Copy link

@kosta kosta commented Nov 27, 2017

Motivation for this change

Update brotli to recent version

Things done
  • [?] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
    • Reason for ?: I'm not sure if the option was actually used
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (debian)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
    • Command used: nix-shell -p nox --run "nox-review wip --against c0c503ca685f5a70390c8f2bb850e8b9690fab17":
      FAILED with error: opening file /nix/store/018yrx4ikn233sq0nmvlrdmcjskqsj64-source.drv: No such file or directory which I cannot trace back to my change...
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej changed the title brotli: 0.6.0 -> 1.0.1; brotli unstable 20160112 -> 20171117 (latest … brotli: 0.6.0 -> 1.0.1 Nov 29, 2017
orivej
orivej approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have redone this PR such as not to break anything, including nginxStable { modules = [ nginxModules.brotli ]; }, and consider it ready.

@kosta
Copy link
Author

kosta commented Nov 29, 2017

Thank you for fixing my incomplete PR! :)

(complete nix noob here)

@adisbladis adisbladis mentioned this pull request Nov 29, 2017
Merged
8 tasks
@orivej orivej merged commit 11520e8 into NixOS:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kosta @orivej @GrahamcOfBorg @Janik-Haag