Suspend thread cleanup #3073
Merged
Suspend thread cleanup #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more explicit that elasticity should be enabled before starting, and that it is not something that should be changed dynamically.
…sticity is disabled
hkaiser
reviewed
Dec 18, 2017
| // because they do not steal work. Periodic priority scheduler not tested | ||
| // because it does not take into account scheduler states when scheduling | ||
| // work. | ||
|
|
There was a problem hiding this comment.
I know we're going to remove those schedulers. Could we add at lest an assert to those until then, making sure nobody uses them in any undue manner?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves enabling elasticity to the test setup before calling
hpx::init, and creates a separate test to check that suspending is only allowed if elasticity is enabled.