Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: 2.93 -> 2.94 #32601

Merged
merged 1 commit into from Dec 14, 2017
Merged

jenkins: 2.93 -> 2.94 #32601

merged 1 commit into from Dec 14, 2017

Conversation

earldouglas
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

I wonder if it would be better if nixpkgs tracked Jenkins LTS releases. Currently we're tracking the weekly releases in both NixOS master and release-17.09, and it feels like a bit too much (IMHO). LTS releases get major updates every 12 weeks, followed by bug and security fixes.

https://jenkins.io/download/

Thoughs?

@earldouglas
Copy link
Member Author

I'm fine with that, although I would want to make sure that LTS updates include all the latest security patches, which come frequently.

Is there anything bad about frequent updates to the Jenkins derivation, other than it feels noisy and costs PR review time?

@bjornfor
Copy link
Contributor

Yes, LTS is supposed to get security fixes.

I get the feeling that the weekly updates also introduce bugs and security issues. (Just skimming through the changelogs.)

@earldouglas earldouglas deleted the jenkins-2.94 branch January 8, 2018 01:05
@earldouglas earldouglas mentioned this pull request Feb 14, 2018
8 tasks
@earldouglas
Copy link
Member Author

earldouglas commented Feb 14, 2018

@bjornfor See #34962 for switching to LTS.

@coretemp
Copy link
Contributor

A good solution to this issue is one where the last 50 releases of Jenkins can be installed via a binary method and every git version could be built from source by simply passing an optional parameter to the package. Since new versions come out each week, the only way to support this is if some daemon would push updates to the Jenkins expression automatically to nixpkgs.

Jenkins upstream cannot be trusted to consistently produce versions that are usable in production.

Once that infrastructure is in place, we can do automated upgrades of Jenkins that don't require any human in the loop anymore.

The current approach in which a single version is sanctioned as being the best for every user of Jenkins does not match real world operations.

This PR is just a symptom of not having enough options. Instead of removing an option (the last weekly release), please do PRs which add options and expand capabilities.

@earldouglas
Copy link
Member Author

every git version could be built from source by simply passing an optional parameter to the package

As a start, I think this should be doable via a combination of #30588 and a package override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants