gnome3.at-spi2-core: Set environment variable NO_AT_BRIDGE=1 if disabled
#32592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Dec 12, 2017
| mkIf !config.services.gnome3.at-spi2-core.enable { | ||
| environment.variables.NO_AT_BRIDGE = "1"; | ||
| } | ||
| ] |
There was a problem hiding this comment.
Whoops... The downside of using Github as an editor. Fixed it.
fmthoma
force-pushed
the
fix-a11y-warnings
branch
from
080a58d
to
ab6e04f
Compare
jtojnar
reviewed
Dec 12, 2017
| environment.systemPackages = [ pkgs.at_spi2_core ]; | ||
| services.dbus.packages = [ pkgs.at_spi2_core ]; | ||
| systemd.packages = [ pkgs.at_spi2_core ]; | ||
| }; |
There was a problem hiding this comment.
Only after the config attribute, lists items are not supposed to end with semicolons.
fmthoma
force-pushed
the
fix-a11y-warnings
branch
from
ab6e04f
to
d2f9d25
Compare
jtojnar
added
the
6.topic: GNOME
|
Hmm, the evaluation still fails |
fmthoma
force-pushed
the
fix-a11y-warnings
branch
from
d2f9d25
to
ee48e7c
Compare
|
Yeah, the parentheses around the negation were missing... |
…abled As suggested in NixOS#16327 (NixOS#16327 (comment)).
fmthoma
force-pushed
the
fix-a11y-warnings
branch
from
ee48e7c
to
a42e9c3
Compare
|
Also added the missing parentheses around the two |
jtojnar
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @jtojnar and @abbradar in #16327.
Motivation for this change
See #16327 (comment)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)