Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

davfs2: create user/group davfs2 if not specified in the configuration #32584

Merged
merged 1 commit into from Dec 17, 2017

Conversation

manoj23
Copy link
Contributor

@manoj23 manoj23 commented Dec 12, 2017

  • Add options:
    • enable
    • davUser (default: "davfs2")
    • davGroup (default: "davfs2)
  • Add davfs2 user or group if they are not specified in the
    configuration
Motivation for this change

cc @peti

pkgs.davfs2 does not work out-of-the-box because I need to add manually the user davfs2 and the group davfs2 for the daemon.
With this change, if the option davUser and davGroup are not specified, it will add the default required user and group.

I tested every possible configuration of davUser/davGroup and their impacts on the /etc/passwd and /etc/group.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

* Add options:
  - enable
  - davUser (default: "davfs2")
  - davGroup (default: "davfs2)
* Add davfs2 user or group if they are not specified in the
configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants