Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libva: 1.7.3 -> 2.0.0 #32599

Merged
merged 3 commits into from Dec 15, 2017
Merged

libva: 1.7.3 -> 2.0.0 #32599

merged 3 commits into from Dec 15, 2017

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Dec 12, 2017 •
edited

Motivation for this change

The vaapi-intel driver is released in accordance with libva releases, so this PR sets up the dependency.

Additionally, the tools previously part of libva are now a separate libva-utils.

This triggers a lot of rebuilding so I haven't tried it out here yet.

Cc: @garbas

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Dec 12, 2017

Please check the eval failure

@peterhoeg
Copy link
Member Author

Messed up the final commit cleanup - thanks for noticing @globin. Sorted now.

@garbas
Copy link
Member

garbas commented Dec 15, 2017

@GrahamcOfBorg eval

@garbas
Copy link
Member

garbas commented Dec 15, 2017

oh damn wrong PR ... i want to merge this :)

@garbas garbas merged commit da864e5 into NixOS:master Dec 15, 2017
@vcunat
Copy link
Member

vcunat commented Dec 15, 2017 •
edited

Why merge to master directly when it's auto-tagged by 10.rebuild-linux: 501+?

@garbas
Copy link
Member

garbas commented Dec 15, 2017

@vcunat oh shit! i must be more careful, i'll revert and push to staging. would that be ok?

@orivej
Copy link
Contributor

orivej commented Dec 15, 2017

Yes.

garbas added a commit that referenced this pull request Dec 15, 2017
@garbas
Reverting #32599
15d3d68
vcunat added a commit that referenced this pull request Dec 15, 2017
@vcunat
Revert "Reverting #32599"
0990b2c 
This reverts commit 15d3d68.
The PR is moved from master to staging.
@vcunat
Copy link
Member

vcunat commented Dec 15, 2017

Moved to staging.

@peterhoeg peterhoeg deleted the u/libva branch December 16, 2017 00:29
@peterhoeg peterhoeg restored the u/libva branch December 16, 2017 00:37
@vcunat
Copy link
Member

vcunat commented Dec 17, 2017

I see the mpv build got broken; hopefully upstream already released an update fixing that... /cc maintainers: @AndersonTorres, @Fuuzetsu, @fpletz.

@orivej
Copy link
Contributor

orivej commented Dec 17, 2017

gst_all_1.gst-vaapi too: Requested 'libva < 0.99.0' but version of libva is 1.0.0.

@peterhoeg peterhoeg deleted the u/libva branch December 18, 2017 01:48
@peterhoeg
Copy link
Member Author

Upstream is recommending carrying both the old and new version - I'll update this to allow for both.

@peterhoeg peterhoeg mentioned this pull request Dec 18, 2017
Closed
8 tasks
@peterhoeg peterhoeg restored the u/libva branch December 18, 2017 14:08
@orivej
Copy link
Contributor

orivej commented Dec 18, 2017 •
edited

It seems that mpv was made compatible with libva 2 in mpv-player/mpv@2ecf240 (not released yet)

@orivej
Copy link
Contributor

orivej commented Dec 18, 2017 •
edited

And gst-vaapi 1.12.4 should already be compatible: GStreamer/gstreamer-vaapi@0d710ed (https://github.com/GStreamer/gstreamer-vaapi/commits/1.12.4)

@orivej
Copy link
Contributor

orivej commented Dec 18, 2017 •
edited

Updated gst-vaapi in b29c78d, this fixed the build.

@orivej
Copy link
Contributor

orivej commented Dec 18, 2017

Fixed mpv by applying the aforementioned patch in 745be0c.

@vcunat
Copy link
Member

vcunat commented Dec 18, 2017

So... we don't need both v1 and v2 (i.e. PR #32796) anymore, right?

@orivej
Copy link
Contributor

orivej commented Dec 19, 2017

I don't know why v1 would be needed.

Upstream is recommending carrying both the old and new version - I'll update this to allow for both.

@peterhoeg Could you post a link?

@peterhoeg
Copy link
Member Author

Could you post a link?

https://github.com/01org/libva/issues/72

@orivej
Copy link
Contributor

orivej commented Dec 19, 2017

Thanks! At this point at least free software we package does not need old libva.

@peterhoeg peterhoeg deleted the u/libva branch December 19, 2017 03:49
@peterhoeg peterhoeg restored the u/libva branch February 25, 2018 14:12
@peterhoeg peterhoeg deleted the u/libva branch April 4, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@peterhoeg @globin @garbas @vcunat @orivej @pSub @GrahamcOfBorg