pythonPackages.dateparser: 0.3.2-pre-2016-01-21 -> 0.6.0 #32591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Dec 12, 2017
| name = "dateparser-${version}"; | ||
| version = "0.6.0"; | ||
|
|
||
| src = fetchgit { |
| # Upstream Issue: https://github.com/scrapinghub/dateparser/issues/364 | ||
| disabled = isPy3k; | ||
|
|
||
| buildInputs = [ nose nose-parameterized mock glibcLocales ]; |
| sha256 = "0q2vyzvlj46r6pr0s6m1a0md1cpg9nv1n3xw286l4x2cc7fj2g3y"; | ||
| }; | ||
|
|
||
| LC_ALL = "en_US.UTF-8"; |
There was a problem hiding this comment.
likely only needed for tests -> export in preCheck
|
|
||
| meta = with stdenv.lib;{ | ||
| description = "Date parsing library designed to parse dates from HTML pages"; | ||
| homepage = https://pypi.python.org/pypi/dateparser; |
There was a problem hiding this comment.
upstream homepage is https://github.com/scrapinghub/dateparser
|
This is what happens when you try to bump a version of some obscure python package 💃 |
makefu
force-pushed
the
pkgs/dateparser/update
branch
from
88863af
to
6cbec9a
Compare
|
Thanks for the review @FRidh 👍 |
FRidh
reviewed
Dec 12, 2017
| , regex | ||
| , ruamel_yaml }: | ||
| buildPythonPackage rec { | ||
| name = "dateparser-${version}"; |
There was a problem hiding this comment.
Just one more tiny change.
pname = "dateparser";
version = "0.6.0";
and drop name.
There was a problem hiding this comment.
ah, that works now! I remember that name was always necessary.
makefu
force-pushed
the
pkgs/dateparser/update
branch
from
6cbec9a
to
d4e0812
Compare
makefu
force-pushed
the
pkgs/dateparser/update
branch
from
d4e0812
to
ba19c2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
unbreak pythonPackages.dateparser, bump to latest rev. This PR is part of the testing for https://github.com/makefu/nix-src-updater .
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)