Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.Libsystem: fix build on 10.13.2 #32317

Merged
merged 1 commit into from Dec 4, 2017
Merged

darwin.Libsystem: fix build on 10.13.2 #32317

merged 1 commit into from Dec 4, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Dec 4, 2017

Motivation for this change

Darwin stdenv does not build on macOS 10.13.2 with the error:

Undefined symbols for architecture x86_64:
  "_host_zone_info", referenced from:
     -reexported_symbols_list command line option
ld: symbol(s) not found for architecture x86_64

You can check with nix-build --no-out-link -A darwin.Libsystem --check.

Things done

I have checked that this fixes stdenv, but I have not rebuilt everything to see if this breaks anything.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej requested review from copumpkin and LnL7 December 4, 2017 18:59
@LnL7
Copy link
Member

LnL7 commented Dec 4, 2017

Hmm, I thought I fixed this in staging.

@LnL7
Copy link
Member

LnL7 commented Dec 4, 2017

Looks like I forgot to merge #31907

@orivej
Copy link
Contributor Author

orivej commented Dec 4, 2017 •
edited

This commit says that it fixes 10.13, so I think that our patch fixes just 10.13.2.

@LnL7
Copy link
Member

LnL7 commented Dec 4, 2017

It could be 10.13.2 specific, the machine I tested with is also running the beta because of the kernel bug.

@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label Dec 4, 2017
@orivej orivej merged commit 7515cdf into NixOS:staging Dec 4, 2017
@orivej orivej mentioned this pull request Dec 4, 2017
Closed
8 tasks
@orivej orivej deleted the macos-10.13.2 branch December 15, 2017 17:16
@orivej orivej added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orivej @LnL7 @vcunat @GrahamcOfBorg