Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: support multiple overrides #32318

Merged
merged 1 commit into from Dec 4, 2017

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 4, 2017

Fixes #32263

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right.

@datakurre
Copy link
Contributor

@FRidh It was that easy :-o And it works with my example use case (layers of overrides due to separation of concerns).

Thanks!

In general, is there any reason to use any other override method than overridePythonAttrs with buildPythonPackage created derivations? And is there known dangers from overusing that? (Beyond possibly slowing down the initial evaluation?)

@FRidh
Copy link
Member Author

FRidh commented Dec 4, 2017

@datakurre buildPythonPackage does some logic before it passes its results to stdenv.mkDerivation. When you use overrideAttrs or overrideDerivation that logic isn't re-executed when you do the overriding.

@FRidh FRidh closed this Dec 4, 2017
@FRidh FRidh reopened this Dec 4, 2017
@FRidh FRidh merged commit ce269c9 into NixOS:master Dec 4, 2017
@FRidh FRidh deleted the python-multiple-overrides branch December 4, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants