Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lumail: 2.9 -> 3.1 #32710

Merged
merged 3 commits into from Mar 12, 2018
Merged

lumail: 2.9 -> 3.1 #32710

merged 3 commits into from Mar 12, 2018

Conversation

matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Dec 15, 2017 •
edited

Motivation for this change

Wanna try out lumail

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This fails for me with

installing
install flags: install SHELL=/nix/store/sxwh6a4v8xdlvg4jf3vl2jh9l5760hsc-bash-4.4-p12/bin/bash LVER=lua PREFIX=\$\(out\) SYSCONFDIR=\$\(out\)/etc gsettingsschemadir=/nix/store/c697qr96a0cbyli667jy3khhglsdvmj4-lumail-3.1/share/gsettings-schemas/lumail-3.1/glib-2.0/schemas/
rm /etc/lumail2/perl.d/delete-message || true
rm: cannot remove '/etc/lumail2/perl.d/delete-message': No such file or directory
rm /etc/lumail2/perl.d/get-folders    || true
rm: cannot remove '/etc/lumail2/perl.d/get-folders': No such file or directory
rm /etc/lumail2/perl.d/get-messages   || true
rm: cannot remove '/etc/lumail2/perl.d/get-messages': No such file or directory
rm /etc/lumail2/perl.d/save-message   || true
rm: cannot remove '/etc/lumail2/perl.d/save-message': No such file or directory
rm /etc/lumail2/perl.d/set-flags      || true
rm: cannot remove '/etc/lumail2/perl.d/set-flags': No such file or directory
rm /etc/lumail2/perl.d/imap-proxy     || true
rm: cannot remove '/etc/lumail2/perl.d/imap-proxy': No such file or directory
rm /etc/lumail2/perl.d/Lumail.pm      || true
rm: cannot remove '/etc/lumail2/perl.d/Lumail.pm': No such file or directory
rmdir /etc/lumail2/perl.d             || true
rmdir: failed to remove '/etc/lumail2/perl.d': No such file or directory
mkdir -p /usr/share/lumail || true
mkdir: cannot create directory '/usr': Permission denied
install -m755 perl.d/imap-proxy /usr/share/lumail/
install: target '/usr/share/lumail/' is not a directory: No such file or directory
make: *** [Makefile:243: install_imap] Error 1
builder for ‘/nix/store/ipd27jim2a0gcc2rc6yhbg77zsw35xcn-lumail-3.1.drv’ failed with exit code 2

I assume that the makeFlags do not properly work. Neither DESTDIR nor PREFIX is overriden, as the log suggests.

@orivej orivej changed the title lumail: 2.9 -> 3.1 [WIP] lumail: 2.9 -> 3.1 Dec 16, 2017
@matthiasbeyer
Copy link
Contributor Author

Tested and works for me.

Please review the package, I made some serious modifications. @orivej

@matthiasbeyer
Copy link
Contributor Author

matthiasbeyer commented Mar 11, 2018 •
edited

Please don't merge. Found a bug.

The lua libs seem not to be loaded. I cannot use "loadstring" for example. Something is wrong.
Filed at lumail/lumail#348 for confirmation.

@matthiasbeyer
Copy link
Contributor Author

I'm currently trying to set the lua path. I fail hard.

@matthiasbeyer
Copy link
Contributor Author

matthiasbeyer commented Mar 11, 2018 •
edited

postInstall does not get called apparently. And if I put the things in the normal installphase, wrapProgram is not found.

@matthiasbeyer
Copy link
Contributor Author

Found the issue: lumail/lumail#348

I will squash the patches if someone approves.

@matthiasbeyer matthiasbeyer mentioned this pull request Mar 12, 2018
Closed
@matthiasbeyer
Copy link
Contributor Author

#36816 documents how to use lua 5.2

This branch uses 5.1, which is the simplest fix for the issue. If requested, I can change the package to use 5.2 (or 5.3, if requested of course).

@matthiasbeyer matthiasbeyer changed the title [WIP] lumail: 2.9 -> 3.1 lumail: 2.9 -> 3.1 Mar 12, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 12, 2018

@GrahamcOfBorg build lumail

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: lumail

No log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: lumail

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/67y8nq17mfch0bn2ni19yc8vmhj5lwjz-lumail-3.1
shrinking /nix/store/67y8nq17mfch0bn2ni19yc8vmhj5lwjz-lumail-3.1/bin/.lumail2-wrapped
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/67y8nq17mfch0bn2ni19yc8vmhj5lwjz-lumail-3.1/bin
patching script interpreter paths in /nix/store/67y8nq17mfch0bn2ni19yc8vmhj5lwjz-lumail-3.1
checking for references to /build in /nix/store/67y8nq17mfch0bn2ni19yc8vmhj5lwjz-lumail-3.1...
/nix/store/67y8nq17mfch0bn2ni19yc8vmhj5lwjz-lumail-3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: lumail

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8dcnmph0gsins3xdc7fqfkp1yqmd7axf-lumail-3.1
shrinking /nix/store/8dcnmph0gsins3xdc7fqfkp1yqmd7axf-lumail-3.1/bin/.lumail2-wrapped
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8dcnmph0gsins3xdc7fqfkp1yqmd7axf-lumail-3.1/bin 
patching script interpreter paths in /nix/store/8dcnmph0gsins3xdc7fqfkp1yqmd7axf-lumail-3.1
checking for references to /tmp/nix-build-lumail-3.1.drv-0 in /nix/store/8dcnmph0gsins3xdc7fqfkp1yqmd7axf-lumail-3.1...
/nix/store/8dcnmph0gsins3xdc7fqfkp1yqmd7axf-lumail-3.1

@matthiasbeyer
Copy link
Contributor Author

Nice. I'll do a squash!

@matthiasbeyer
lumail: 2.9 -> 3.1
29c33ba
@matthiasbeyer
lumail: Fix package definition
bb8e1c4 
Includes:

* Package gets a flag to use the debug build
* install phase installs all lua scripts from the package and makes
  lumail find them
* global configuration which is shipped with the package can be
  overridden, if desired
* parallel building enabled
@matthiasbeyer
lumail: Use lua5.1
13e95f3 
This is necessary because the standard library which is distributed with
lumail (the lumail core configuration so to speak) is written for lua5.1
apparently.

The website states 5.1 or 5.2 or 5.3, but 5.2 fails because "loadstring"
was deprecated in lua 5.2.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Copy link
Contributor Author

Ready for merging, IMO.

@Mic92 Mic92 merged commit 2f00a50 into NixOS:master Mar 12, 2018
@matthiasbeyer matthiasbeyer deleted the update-lumail branch March 12, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @Mic92 @GrahamcOfBorg