New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore build warnings #3079
Ignore build warnings #3079
Conversation
# pragma clang diagnostic pop | ||
#elif defined (__GNUC__) | ||
# pragma GCC diagnostic pop | ||
#endif | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wrap this into a separate header file instead of wrapping all #include <mpi.h>
with this #pragma goo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a good idea. I've updated the PR with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This ignores build warnings that we can't fix using
#pragma diagnostic GCC/clang ignored ...
.