perl generic builder: recognize #!/usr/bin/env perl #32717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
approved these changes
Dec 15, 2017
|
@grahamc Is the checkMeta error meant to prevent the "rebuild-linux" and "rebuild-darwin" tags, or is there something else wrong? |
|
The current staging is slightly broken with respect to eval check meta, it can be fixed by merging master into staging, but does not matter for this PR. |
|
It should not prevent labeling, can you open an issue at the grahamc/ofborg github repo? |
|
@GrahamcOfBorg eval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
While upgrading biber to 2.7, I noticed that the shebang-patcher in the perl builder only recognizes
/usr/bin/perl, but not/usr/bin/env perl. I also simplified the sed call with the-iin-place option (hope this works on darwin).This rebuilds all packages that depend on perl modules. I did not find any problems, but I did not rebuild everything.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)