Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression issue of vscode-languageclient since v3.0.0 #290

Closed
hokein opened this issue Dec 15, 2017 · 0 comments
Closed

Regression issue of vscode-languageclient since v3.0.0 #290

hokein opened this issue Dec 15, 2017 · 0 comments
Milestone
January 2018

Comments

@hokein
Copy link
Contributor

hokein commented Dec 15, 2017

We are working on clangd (a LSP for C++), we find an issue of vscode-languageclient starting from v3.0.0.

The severity field of the diagnostics has been omitted in the codeAction request sent from VScode.
Particularly, this is happened when severity == 1. See the sample below:

// test code
void main() {
}

Output since v3.0.0

<-- {
  "id": 10,
  "jsonrpc": "2.0",
  "method": "textDocument/codeAction",
  "params": {
    "context": {
      "diagnostics": [
        {
          "message": "'main' must return 'int'",
          "range": {
            "end": {
              "character": 4,
              "line": 18
            },
            "start": {
              "character": 0,
              "line": 18
            }
          }
        }
      ]
    },
    "range": {
      "end": {
        "character": 4,
        "line": 18
      },
      "start": {
        "character": 0,
        "line": 18
      }
    },
    "textDocument": {
      "uri": "file:///tmp/t.cc"
    }
  }
}

Output at v2.6.0:

{
  "id": 4,
  "jsonrpc": "2.0",
  "method": "textDocument/codeAction",
  "params": {
    "context": {
      "diagnostics": [
        {
          "message": "'main' must return 'int'",
          "range": {
            "end": {
              "character": 4,
              "line": 18
            },
            "start": {
              "character": 0,
              "line": 18
            }
          },
          "severity": 1
        }
      ]
    },
    "range": {
      "end": {
        "character": 4,
        "line": 18
      },
      "start": {
        "character": 0,
        "line": 18
      }
    },
    "textDocument": {
      "uri": "file:///tmp/t.cc"
    }
  }
}
@dbaeumer dbaeumer added this to the January 2018 milestone Dec 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
2 participants
@dbaeumer @hokein