Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddgr: init at 1.1 #32222

Merged
merged 1 commit into from Dec 5, 2017
Merged

ddgr: init at 1.1 #32222

merged 1 commit into from Dec 5, 2017

Conversation

markus1189
Copy link
Contributor

Motivation for this change

Add the ddgr package: https://github.com/jarun/ddgr

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@markus1189
Copy link
Contributor Author

Oops wait a moment, forgot the completions

@markus1189
Copy link
Contributor Author

Okay, now with completions. Somehow the one for bash works, while the one for zsh does not... Does anybody see an error?

@Mic92
Copy link
Member

Mic92 commented Dec 1, 2017

I guess there is a small typo:

- '(-t --time'{-t,--time}'[limit search duration]:d/w/m'
+ '(-t --time)'{-t,--time}'[limit search duration]:d/w/m'

this could be also fixed upstream.

@markus1189 markus1189 mentioned this pull request Dec 3, 2017
Merged
@Mic92
Copy link
Member

Mic92 commented Dec 4, 2017

You can now use fetchpatch to apply this change to this package.

@markus1189
Copy link
Contributor Author

Thanks for the hint, I am now using fetchpatch

@Mic92 Mic92 merged commit 3228556 into NixOS:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markus1189 @Mic92 @GrahamcOfBorg