Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qesteidutil: 3.12.5.1233 -> 3.12.10 #32231

Merged
merged 1 commit into from Dec 1, 2017
Merged

qesteidutil: 3.12.5.1233 -> 3.12.10 #32231

merged 1 commit into from Dec 1, 2017

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Dec 1, 2017 •
edited

Motivation for this change

Required by nox-review for #32100

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

adisbladis
adisbladis requested changes Dec 1, 2017
View reviewed changes
pkgs/tools/security/qesteidutil/default.nix
# We require the remove breakpad stuff
rev = "efdfe4c5521f68f206569e71e292a664bb9f46aa";
sha256 = "0zly83sdqsf9lxnfw4ir2a9vmmfba181rhsrz61ga2zzpm2wf0f0";
fetchSubmodules = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use fetchurl and apply the necessary commit(s) as a patch with fetchpatch rather than using fetchFromGithub with fetchSubmodules = true.

Copy link
Contributor Author

@bkchr bkchr Dec 1, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, but the commit contains changes to the sub repository. Thus, I could not apply the patch by fetchpatch (it failed) :/

@Mic92 Mic92 merged commit dd40eae into NixOS:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @adisbladis @Mic92 @GrahamcOfBorg