Dead Exception in RealClassGenerator #4880

nick-someone · 2017-12-01T17:28:02Z

Line 147 in 355f943

    
           new RuntimeException(newClass.getInterfaces()[0].getClassLoader() + " " + interfaces[0].getClassLoader());

This line creates an exception, but doesn't throw it. If thrown, a number of CI tests fail: https://travis-ci.org/jruby/jruby/builds/305072247

This condition/exception should be removed if it's not needed, or the exception should be thrown and the relevant tests fixed.

headius · 2017-12-05T16:55:46Z

The fact that so many tests fail tells me this condition is no longer valid, but I'll take a deeper look.

headius · 2017-12-05T17:13:16Z

The condition is backwards. I'll fix in a moment.

Fixes #4880.

nick-someone mentioned this issue Dec 1, 2017

Fix issues discovered using Error Prone #4860

Merged

headius added this to the JRuby 9.1.15.0 milestone Dec 5, 2017

headius closed this as completed Dec 5, 2017

Provide feedback