Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xorg.fontmiscmisc: make the misc fonts available #32223

Merged
merged 1 commit into from Dec 1, 2017
Merged

xorg.fontmiscmisc: make the misc fonts available #32223

merged 1 commit into from Dec 1, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Dec 1, 2017

Motivation for this change

Xorg was rejecting font directories with symlinks since db6adec.

Tested with:

misc=$(nix-build '<nixpkgs>' -A xorg.fontmiscmisc)/lib/X11/fonts/misc
xset fp+ $misc

The old output is:

xset:  bad font path element (#11), possible causes are:
    Directory does not exist or has wrong permissions
    Directory missing fonts.dir
    Incorrect font server address or syntax

and the new is empty, after which xlsfonts, xfontsel list all -misc-fixed fonts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
xorg.fontmiscmisc: make the misc fonts available
6eddd80 
Xorg was rejecting font directories with symlinks since
db6adec.
@orivej orivej requested a review from vcunat December 1, 2017 10:49
@vcunat vcunat added 0.kind: regression Something that worked before working no longer 6.topic: nixos 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 1, 2017
@vcunat vcunat merged commit 6eddd80 into NixOS:master Dec 1, 2017
vcunat added a commit that referenced this pull request Dec 1, 2017
@vcunat
Merge #32223: xorg.fontmiscmisc: make the fonts available
7def2a8 
Needed due to upstream security fix:
https://cgit.freedesktop.org/xorg/lib/libXfont/commit/?id=7b377456f95d
vcunat added a commit that referenced this pull request Dec 1, 2017
@vcunat
Merge #32223: xorg.fontmiscmisc: make the fonts available
559ebb7 
Needed due to upstream security fix:
https://cgit.freedesktop.org/xorg/lib/libXfont/commit/?id=7b377456f95d

(cherry picked from commit 7def2a8)
@orivej orivej added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 1, 2017
@orivej orivej deleted the font-misc branch December 1, 2017 18:45
@orivej orivej mentioned this pull request Dec 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 6.topic: nixos 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @vcunat @GrahamcOfBorg