renderdoc: Fixes build with missing SWIG_PACKAGE #32230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Dec 1, 2017
| nativeBuildInputs = [ cmake makeWrapper pkgconfig python3 bison autoconf automake pcre ]; | ||
|
|
||
| SWIG_PACKAGE = fetchurl { | ||
| url = "https://github.com/baldurk/swig/archive/renderdoc-modified-1.zip"; | ||
| sha256 = "0xxvkkaa5rp2xnnms6i1i4kbvq9fj3is0kiawwdix4hfys16m4mz"; |
There was a problem hiding this comment.
There was a problem hiding this comment.
These tarballs are generated by github. On regeneration they might change also the content does not change. Therefor it is required fetchzip or even better fetchFromGitHub, which is a wrapper around fetchzip.
There was a problem hiding this comment.
Okay, I already tried fetchFromGitHub, but gave up after some tries. I will try again, I think I have an idea was is wrong.
There was a problem hiding this comment.
@bkchr What errors did you encounter?
bkchr
force-pushed
the
renderdoc
branch
2 times, most recently
from
dacc8ef
to
29d0f99
Compare
|
Reminder for @Mic92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Required by nox-review for #32100
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)