Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitwig-studio: refactor to support older major versions #33310

Merged
merged 1 commit into from Jan 2, 2018

Conversation

mrVanDalo
Copy link
Contributor

Motivation for this change

As discussed in #32206 bitwig has multiple major versions, and a license model that needs people to pay to use the newest versions. So people like me who only own the version 1, we should support older major versions as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mrVanDalo
Copy link
Contributor Author

@yegortimoshenko the only thing I'm not 100% sure is how to integrated it into top-level/all-packages.nix.

@lukateras
Copy link
Member

Both bitwig-studio1 and bitwig-studio2 work. Thank you!

@lukateras lukateras merged commit e8adb89 into NixOS:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants