Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: fix armv7l-linux support in new binary versions. #33327

Merged
merged 1 commit into from
Jan 2, 2018
Merged

ghc: fix armv7l-linux support in new binary versions. #33327

merged 1 commit into from
Jan 2, 2018
+2 −2

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Jan 2, 2018

Motivation for this change

Typos in 7.10.3-binary.nix and 8.2.1-binary.nix prevent armv7l-linux builds from evaluating.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [dx] Fits CONTRIBUTING.md.

Sorry, something went wrong.

@dhess
ghc: fix armv7l-linux support in new binary versions.

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 91BE884FBA4B591A
Learn about vigilant mode
9c91d0d
@dhess dhess requested a review from peti as a code owner January 2, 2018 11:42
@peti peti merged commit 6ad2c20 into NixOS:master Jan 2, 2018
@dhess dhess deleted the armv7l-ghc-fix branch January 2, 2018 11:48
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhess @peti @GrahamcOfBorg