webkitgtk: Fix webkitgtk for macOS #33307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build webkitgtk |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
#if !__BIG_ENDIAN__ && !__LITTLE_ENDIAN__
^
/nix/store/ib67r0hzmdfyv0q68y3z632xpd2pd9a5-CF-osx-10.10.5-private/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:39:5: warning: '__BIG_ENDIAN__' is not defined, evaluates to 0 [-Wundef]
#if __BIG_ENDIAN__ && __LITTLE_ENDIAN__
^
/nix/store/ib67r0hzmdfyv0q68y3z632xpd2pd9a5-CF-osx-10.10.5-private/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:363:5: warning: '__LLP64__' is not defined, evaluates to 0 [-Wundef]
#if __LLP64__
^
building of ‘/nix/store/m7abfcmrbnn7b3b709ghsk4nlh5hjk6b-webkitgtk-2.18.4.drv’ timed out after 1800 seconds
error: build of ‘/nix/store/m7abfcmrbnn7b3b709ghsk4nlh5hjk6b-webkitgtk-2.18.4.drv’ failed
There was a problem hiding this comment.
Failure for system: x86_64-linux
[ 23%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/SetPrototype.cpp.o
[ 23%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringConstructor.cpp.o
[ 23%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/SetIteratorPrototype.cpp.o
[ 23%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/SetConstructor.cpp.o
[ 23%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringIteratorPrototype.cpp.o
[ 23%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringObject.cpp.o
[ 23%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringPrototype.cpp.o
[ 23%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/SymbolConstructor.cpp.o
building of ‘/nix/store/l5h255j0cziyf5jpz5idgdh5vkq6jiqv-webkitgtk-2.18.4.drv’ timed out after 1800 seconds
error: build of ‘/nix/store/l5h255j0cziyf5jpz5idgdh5vkq6jiqv-webkitgtk-2.18.4.drv’ failed
|
cc @LnL7 |
There was a problem hiding this comment.
Failure for system: aarch64-linux
[ 39%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/MathMLNames.cpp.o
[ 39%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/XLinkNames.cpp.o
[ 40%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSSVGElementWrapperFactory.cpp.o
[ 40%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/SVGElementFactory.cpp.o
[ 40%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/SVGNames.cpp.o
[ 40%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/MathMLElementFactory.cpp.o
[ 40%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/XMLNSNames.cpp.o
[ 40%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/XMLNames.cpp.o
building of '/nix/store/5kx1hwh6salag7h86krxzk83rsjdik3z-webkitgtk-2.18.4.drv' timed out after 3600 seconds
error: build of '/nix/store/5kx1hwh6salag7h86krxzk83rsjdik3z-webkitgtk-2.18.4.drv' failed
hamishmack
force-pushed
the
webkitgtk-macos
branch
from
70e7717
to
7a26949
Compare
hamishmack
force-pushed
the
webkitgtk-macos
branch
from
7a26949
to
a5273b5
Compare
8 tasks
hamishmack
force-pushed
the
webkitgtk-macos
branch
from
a5273b5
to
646af90
Compare
hamishmack
force-pushed
the
webkitgtk-macos
branch
from
646af90
to
ed8f507
Compare
hamishmack
force-pushed
the
webkitgtk-macos
branch
from
ed8f507
to
e15189b
Compare
| @@ -24,6 +24,8 @@ stdenv.mkDerivation rec { | |||
| nativeBuildInputs = [ pkgconfig intltool ]; | |||
| propagatedBuildInputs = [ glib gnutls libproxy gsettings_desktop_schemas ]; | |||
|
|
|||
| NIX_LDFLAGS = stdenv.lib.optionalString stdenv.isDarwin "-lintl"; | |||
There was a problem hiding this comment.
This should no longer be required.
|
Are there any updates on this pull request, please? |
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Should be resolved by #123298 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The latest webkitgtk in nixpkgs does not currently build on macOS. This fixes thew build and webkitgtk seems to work correctly on macOS.
I have included PR #33304 (fixes geoclue2 on macOS) in this PR as it is also needed for this to work (since webkitgtk uses geoclue2).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)