Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delve: Build on darwin #33326

Merged
merged 1 commit into from Jan 2, 2018
Merged

delve: Build on darwin #33326

merged 1 commit into from Jan 2, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jan 2, 2018

Motivation for this change

Build delve on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @vdemeester

@adisbladis
Copy link
Member Author

@GrahamcOfBorg build delve

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘delve-0.12.2’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/tools/delve/default.nix:18 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

patching script interpreter paths in /nix/store/7bmknfic533rr581zmzsx0cwqbln119k-delve-0.12.2-bin
checking for references to /tmp/nix-build-delve-0.12.2.drv-0 in /nix/store/7bmknfic533rr581zmzsx0cwqbln119k-delve-0.12.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/6xmdpbc162bpdh8i7c5a7wvf9nkfzmx0-delve-0.12.2
patching script interpreter paths in /nix/store/6xmdpbc162bpdh8i7c5a7wvf9nkfzmx0-delve-0.12.2
/nix/store/6xmdpbc162bpdh8i7c5a7wvf9nkfzmx0-delve-0.12.2/share/go/src/github.com/derekparker/delve/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/6xmdpbc162bpdh8i7c5a7wvf9nkfzmx0-delve-0.12.2/share/go/src/github.com/derekparker/delve/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/6xmdpbc162bpdh8i7c5a7wvf9nkfzmx0-delve-0.12.2/share/go/src/github.com/derekparker/delve/scripts/testsign: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
/nix/store/6xmdpbc162bpdh8i7c5a7wvf9nkfzmx0-delve-0.12.2/share/go/src/github.com/derekparker/delve/scripts/gencert.sh: interpreter directive changed from "/bin/bash" to "/nix/store/65l6hr8snf4v823f974k97jc65i7bhvf-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-delve-0.12.2.drv-0 in /nix/store/6xmdpbc162bpdh8i7c5a7wvf9nkfzmx0-delve-0.12.2...
/nix/store/7bmknfic533rr581zmzsx0cwqbln119k-delve-0.12.2-bin

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/private/tmp/nix-build-delve-0.12.2.drv-0
post-installation fixup
stripping (with flags -S) in /nix/store/nvxy4rm0yd9663x12wynsiac7zns50x5-delve-0.12.2-bin/bin 
patching script interpreter paths in /nix/store/nvxy4rm0yd9663x12wynsiac7zns50x5-delve-0.12.2-bin
patching script interpreter paths in /nix/store/h85ncnzf7h2f0il91h6rx7a4rkyf8fbg-delve-0.12.2
/nix/store/h85ncnzf7h2f0il91h6rx7a4rkyf8fbg-delve-0.12.2/share/go/src/github.com/derekparker/delve/scripts/testsign: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/h85ncnzf7h2f0il91h6rx7a4rkyf8fbg-delve-0.12.2/share/go/src/github.com/derekparker/delve/scripts/gencert.sh: interpreter directive changed from "/bin/bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/h85ncnzf7h2f0il91h6rx7a4rkyf8fbg-delve-0.12.2/share/go/src/github.com/derekparker/delve/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/h85ncnzf7h2f0il91h6rx7a4rkyf8fbg-delve-0.12.2/share/go/src/github.com/derekparker/delve/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/hiv85an0qyzj6ps88f5pvkbbdj8238nj-bash-4.4-p12/bin/bash"
/nix/store/nvxy4rm0yd9663x12wynsiac7zns50x5-delve-0.12.2-bin

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌞

@adisbladis adisbladis merged commit d7ab19d into NixOS:master Jan 2, 2018
@adisbladis
Copy link
Member Author

Pushed in d7ab19d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants