Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: 17.{09,11} -> 17.12 #33329

Merged
merged 1 commit into from Jan 3, 2018
Merged

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update to edge and LTS releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The nix tests fail for me, so let's see what borg says...

@NeQuissimus NeQuissimus added 8.has: package (update) 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 2, 2018
@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg build docker

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

2018/01/02 12:36:22 WARN: man/src/trust/view.md does not exist, skipping
2018/01/02 12:36:22 WARN: man/src/trust.md does not exist, skipping
2018/01/02 12:36:22 WARN: man/src/volume/prune.md does not exist, skipping
2018/01/02 12:36:22 WARN: man/src/volume/rm.md does not exist, skipping
Generate legacy manpages
post-installation fixup
patching script interpreter paths in /nix/store/jlys8kpk4w0b54k6gczjixwlk4l7df5n-docker-17.12.0-ce
gzipping man pages under /nix/store/lrgyqg1qb3wvz0n8jbjrf5xq5chbs30b-docker-17.12.0-ce-man/share/man/
patching script interpreter paths in /nix/store/lrgyqg1qb3wvz0n8jbjrf5xq5chbs30b-docker-17.12.0-ce-man
/nix/store/jlys8kpk4w0b54k6gczjixwlk4l7df5n-docker-17.12.0-ce

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking RPATHs of ELF executables and libraries in /nix/store/nwgsxm8d99ymr371la8ksfijh7p7qd2d-docker-17.12.0-ce
shrinking /nix/store/nwgsxm8d99ymr371la8ksfijh7p7qd2d-docker-17.12.0-ce/libexec/docker/docker
shrinking /nix/store/nwgsxm8d99ymr371la8ksfijh7p7qd2d-docker-17.12.0-ce/libexec/docker/dockerd
patching script interpreter paths in /nix/store/nwgsxm8d99ymr371la8ksfijh7p7qd2d-docker-17.12.0-ce
checking for references to /tmp/nix-build-docker-17.12.0-ce.drv-0 in /nix/store/nwgsxm8d99ymr371la8ksfijh7p7qd2d-docker-17.12.0-ce...
shrinking RPATHs of ELF executables and libraries in /nix/store/vb9vqgxz1sqhwmiivrhffi0cdp9fldkm-docker-17.12.0-ce-man
gzipping man pages under /nix/store/vb9vqgxz1sqhwmiivrhffi0cdp9fldkm-docker-17.12.0-ce-man/share/man/
patching script interpreter paths in /nix/store/vb9vqgxz1sqhwmiivrhffi0cdp9fldkm-docker-17.12.0-ce-man
checking for references to /tmp/nix-build-docker-17.12.0-ce.drv-0 in /nix/store/vb9vqgxz1sqhwmiivrhffi0cdp9fldkm-docker-17.12.0-ce-man...
/nix/store/nwgsxm8d99ymr371la8ksfijh7p7qd2d-docker-17.12.0-ce

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

shrinking RPATHs of ELF executables and libraries in /nix/store/sk1fqvsil27izac5zmy20asqwcvvxjhj-docker-17.12.0-ce
shrinking /nix/store/sk1fqvsil27izac5zmy20asqwcvvxjhj-docker-17.12.0-ce/libexec/docker/docker
shrinking /nix/store/sk1fqvsil27izac5zmy20asqwcvvxjhj-docker-17.12.0-ce/libexec/docker/dockerd
patching script interpreter paths in /nix/store/sk1fqvsil27izac5zmy20asqwcvvxjhj-docker-17.12.0-ce
checking for references to /build in /nix/store/sk1fqvsil27izac5zmy20asqwcvvxjhj-docker-17.12.0-ce...
shrinking RPATHs of ELF executables and libraries in /nix/store/4bybslgdnw87ixl4j4nfds396jzm9wn9-docker-17.12.0-ce-man
gzipping man pages under /nix/store/4bybslgdnw87ixl4j4nfds396jzm9wn9-docker-17.12.0-ce-man/share/man/
patching script interpreter paths in /nix/store/4bybslgdnw87ixl4j4nfds396jzm9wn9-docker-17.12.0-ce-man
checking for references to /build in /nix/store/4bybslgdnw87ixl4j4nfds396jzm9wn9-docker-17.12.0-ce-man...
/nix/store/sk1fqvsil27izac5zmy20asqwcvvxjhj-docker-17.12.0-ce

@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg test docker

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

docker: exit status 1
docker: output: 
error: command `[ $(docker version | grep 17.12.0-ce | wc -l) = "2" ]' did not succeed (exit code 1)
command `[ $(docker version | grep 17.12.0-ce | wc -l) = "2" ]' did not succeed (exit code 1)
cleaning up
killing docker (pid 173)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-docker.drv-0/vde1.ctl': Directory not empty
builder for ‘/nix/store/wr1lh400s7gimwkicka6mcp9al8cyl0i-vm-test-run-docker.drv’ failed with exit code 255
error: build of ‘/nix/store/wr1lh400s7gimwkicka6mcp9al8cyl0i-vm-test-run-docker.drv’ failed

@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg test docker

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

docker: exit status 1
syncing
docker: running command: sync
docker: exit status 0
test script finished in 18.12s
cleaning up
killing docker (pid 173)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-docker.drv-0/vde1.ctl': Directory not empty
/nix/store/hxz891chsy76m1km3craym7yglap7sjh-vm-test-run-docker

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@NeQuissimus NeQuissimus merged commit bbb04db into NixOS:master Jan 3, 2018
@NeQuissimus NeQuissimus deleted the docker_17_12 branch January 3, 2018 15:36
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants