Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yabar-unstable: 2017-10-12 -> 2018-01-02 #33317

Merged
merged 1 commit into from Jan 2, 2018
Merged

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 2, 2018

Motivation for this change

The unstable branch of yabar received some minor useful changes:

The last change requires a libxkbcommon as additional build input.

Furthermore I thought that it might be better to add the dependencies of
unstable (namely playerctl and libxkbcommon) to the unstable.nix
to reduce the closure size of the stable build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The unstable branch of `yabar` received some minor useful changes:

- Fixed missprint (geommer/yabar@f1b1eff)
- Update information on Debian installation (geommer/yabar@ce20fe7)
- Add indicator to show current indicator using `libxkbcommon` (geommer/yabar@5aa1fb5)

The last change requires a `libxkbcommon` as additional build input.

Furthermore I thought that it might be better to add the dependencies of
unstable (namely `playerctl` and `libxkbcommon`) to the `unstable.nix`
to reduce the closure size of the stable build.
@adisbladis
Copy link
Member

@GrahamcOfBorg build yabar-unstable

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘yabar-unstable-2018-01-02’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/window-managers/yabar/build.nix:46 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

'examples/example.config' -> '/nix/store/ry0mjd8raa12yih6p49yfcln8zj4fyzw-yabar-unstable-2018-01-02/share/yabar/examples/example.config'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ry0mjd8raa12yih6p49yfcln8zj4fyzw-yabar-unstable-2018-01-02
shrinking /nix/store/ry0mjd8raa12yih6p49yfcln8zj4fyzw-yabar-unstable-2018-01-02/bin/yabar
gzipping man pages under /nix/store/ry0mjd8raa12yih6p49yfcln8zj4fyzw-yabar-unstable-2018-01-02/share/man/
stripping (with flags -S) in /nix/store/ry0mjd8raa12yih6p49yfcln8zj4fyzw-yabar-unstable-2018-01-02/bin 
patching script interpreter paths in /nix/store/ry0mjd8raa12yih6p49yfcln8zj4fyzw-yabar-unstable-2018-01-02
checking for references to /tmp/nix-build-yabar-unstable-2018-01-02.drv-0 in /nix/store/ry0mjd8raa12yih6p49yfcln8zj4fyzw-yabar-unstable-2018-01-02...
/nix/store/ry0mjd8raa12yih6p49yfcln8zj4fyzw-yabar-unstable-2018-01-02

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

'examples/example.config' -> '/nix/store/8ij73a1x2kp7kyc112mi28bpsx1h6jy9-yabar-unstable-2018-01-02/share/yabar/examples/example.config'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8ij73a1x2kp7kyc112mi28bpsx1h6jy9-yabar-unstable-2018-01-02
shrinking /nix/store/8ij73a1x2kp7kyc112mi28bpsx1h6jy9-yabar-unstable-2018-01-02/bin/yabar
gzipping man pages under /nix/store/8ij73a1x2kp7kyc112mi28bpsx1h6jy9-yabar-unstable-2018-01-02/share/man/
stripping (with flags -S) in /nix/store/8ij73a1x2kp7kyc112mi28bpsx1h6jy9-yabar-unstable-2018-01-02/bin
patching script interpreter paths in /nix/store/8ij73a1x2kp7kyc112mi28bpsx1h6jy9-yabar-unstable-2018-01-02
checking for references to /build in /nix/store/8ij73a1x2kp7kyc112mi28bpsx1h6jy9-yabar-unstable-2018-01-02...
/nix/store/8ij73a1x2kp7kyc112mi28bpsx1h6jy9-yabar-unstable-2018-01-02

@adisbladis
Copy link
Member

@GrahamcOfBorg build yabar

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘yabar-0.4.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/window-managers/yabar/build.nix:46 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

'examples/internal1.config' -> '/nix/store/mv4hbhly045zxgxn2g5mar88gnsaknha-yabar-0.4.0/share/yabar/examples/internal1.config'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mv4hbhly045zxgxn2g5mar88gnsaknha-yabar-0.4.0
shrinking /nix/store/mv4hbhly045zxgxn2g5mar88gnsaknha-yabar-0.4.0/bin/yabar
gzipping man pages under /nix/store/mv4hbhly045zxgxn2g5mar88gnsaknha-yabar-0.4.0/share/man/
stripping (with flags -S) in /nix/store/mv4hbhly045zxgxn2g5mar88gnsaknha-yabar-0.4.0/bin
patching script interpreter paths in /nix/store/mv4hbhly045zxgxn2g5mar88gnsaknha-yabar-0.4.0
checking for references to /build in /nix/store/mv4hbhly045zxgxn2g5mar88gnsaknha-yabar-0.4.0...
/nix/store/mv4hbhly045zxgxn2g5mar88gnsaknha-yabar-0.4.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

'examples/internal1.config' -> '/nix/store/kpzawc3zckcwxbndfv7vcyqs2nmv7z5w-yabar-0.4.0/share/yabar/examples/internal1.config'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kpzawc3zckcwxbndfv7vcyqs2nmv7z5w-yabar-0.4.0
shrinking /nix/store/kpzawc3zckcwxbndfv7vcyqs2nmv7z5w-yabar-0.4.0/bin/yabar
gzipping man pages under /nix/store/kpzawc3zckcwxbndfv7vcyqs2nmv7z5w-yabar-0.4.0/share/man/
stripping (with flags -S) in /nix/store/kpzawc3zckcwxbndfv7vcyqs2nmv7z5w-yabar-0.4.0/bin 
patching script interpreter paths in /nix/store/kpzawc3zckcwxbndfv7vcyqs2nmv7z5w-yabar-0.4.0
checking for references to /tmp/nix-build-yabar-0.4.0.drv-0 in /nix/store/kpzawc3zckcwxbndfv7vcyqs2nmv7z5w-yabar-0.4.0...
/nix/store/kpzawc3zckcwxbndfv7vcyqs2nmv7z5w-yabar-0.4.0

@adisbladis
Copy link
Member

LGTM 👍

@adisbladis adisbladis merged commit aa0d820 into NixOS:master Jan 2, 2018
@Ma27 Ma27 deleted the update-yabar branch January 2, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants