Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: add ARM variants to meta.platforms for new binary versions. #33328

Merged
merged 1 commit into from Jan 2, 2018
Merged

ghc: add ARM variants to meta.platforms for new binary versions. #33328

merged 1 commit into from Jan 2, 2018

Conversation

dhess
Copy link
Contributor

@dhess dhess commented Jan 2, 2018

Motivation for this change

7.10.3-binary.nix supports armv7l-linux but this is not present in meta.platforms.

8.2.1-binary.nix supports armv7l-linux and aarch64-linux, but neither is present in meta.platforms.

I just kicked off a ghc822 build on armv7l-linux and it now evaluates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dhess dhess requested a review from peti as a code owner January 2, 2018 12:05
@peti peti merged commit ed1bd10 into NixOS:master Jan 2, 2018
@dhess dhess deleted the ghc-arm-platforms branch January 2, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhess @peti @GrahamcOfBorg