Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UUID.new URN string exception typos #5507

Merged
merged 2 commits into from Jan 2, 2018
Merged

Fix UUID.new URN string exception typos #5507

merged 2 commits into from Jan 2, 2018

Conversation

lachlan
Copy link
Contributor

@lachlan lachlan commented Jan 2, 2018

Fixes a couple of exception message typos when parsing a URN string in UUID.new:

  1. Expected size was incorrectly quoted as 46 rather than 45 characters
  2. Expected prefix was incorrectly quoted as starting with a : character

@RX14 RX14 added this to the Next milestone Jan 2, 2018
@RX14 RX14 merged commit 687d665 into crystal-lang:master Jan 2, 2018
lukeasrodgers pushed a commit to lukeasrodgers/crystal that referenced this pull request Jan 7, 2018
@lachlan @lukeasrodgers
Fix UUID.new URN string exception typos (crystal-lang#5507)
7eef141 
* Fix UUID.new exception typo in expected URN string size

* Fix UUID.new exception typo in expected URN string prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lachlan @asterite @RX14