Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphviz: cleanup, use autoreconfHook, source from GitLab #32731

Merged
merged 1 commit into from Dec 16, 2017
Merged

graphviz: cleanup, use autoreconfHook, source from GitLab #32731

merged 1 commit into from Dec 16, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Dec 16, 2017 •
edited

Motivation for this change

Fixes #32708.

v2.32 doesn't have a proper tag (they only recently moved to Git), so instead sha1 is used as a rev, see: https://gitlab.com/graphviz/graphviz/commit/10c3c34c5198beacfba950764f34960c6884a34f

/cc @Fuuzetsu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras lukateras changed the title graphviz: cleanup, source from GitLab graphviz: cleanup, use autoreconfHook, source from GitLab Dec 16, 2017
joachifm
joachifm reviewed Dec 16, 2017
View reviewed changes
pkgs/tools/graphics/graphviz/base.nix Outdated

meta = with stdenv.lib; {
homepage = https://graphviz.org;
description = "Praph visualization tools";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here, I think

@7c6f434c
Copy link
Member

Looks good modulo the typo.

@lukateras
Copy link
Member Author

lukateras commented Dec 16, 2017 •
edited

@7c6f434c Fixed the typo. @joachifm, thanks for noticing!

@7c6f434c 7c6f434c merged commit 7c91237 into NixOS:master Dec 16, 2017
@lukateras lukateras deleted the graphviz/src branch December 18, 2017 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukateras @7c6f434c @joachifm @GrahamcOfBorg