pinentry: 1.0.0 → 1.1.0 #32733
Merged
pinentry: 1.0.0 → 1.1.0 #32733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build pinentry pinentry_ncurses pinentry_gnome pinentry_qt4 pinentry_qt5 |
There was a problem hiding this comment.
Success for system: x86_64-linux
stripping (with flags -S) in /nix/store/3nb20yxc558xqdmwnk99jvrnjdfijcvl-pinentry-1.1.0/bin
patching script interpreter paths in /nix/store/3nb20yxc558xqdmwnk99jvrnjdfijcvl-pinentry-1.1.0
checking for references to /tmp/nix-build-pinentry-1.1.0.drv-0 in /nix/store/3nb20yxc558xqdmwnk99jvrnjdfijcvl-pinentry-1.1.0...
postPatchMkspecs
postMoveQtStaticLibs
/nix/store/jpg0aqijw7wk9vl42790vbkg541zsc38-pinentry-1.1.0
/nix/store/h3hi16fr0vfl1iyda52c6aar9vz32y5k-pinentry-1.1.0
/nix/store/9ayc60gywrxg1pc951hfv1zjcsni0f8h-pinentry-1.1.0
/nix/store/0s10ylz1i276br78x0xmpq5kc9ylacpf-pinentry-1.1.0
/nix/store/3nb20yxc558xqdmwnk99jvrnjdfijcvl-pinentry-1.1.0
There was a problem hiding this comment.
Success for system: aarch64-linux
stripping (with flags -S) in /nix/store/x3fiiwsqbwxfdj5r3iz0r18shcnlcrdv-pinentry-1.1.0/bin
patching script interpreter paths in /nix/store/x3fiiwsqbwxfdj5r3iz0r18shcnlcrdv-pinentry-1.1.0
checking for references to /build in /nix/store/x3fiiwsqbwxfdj5r3iz0r18shcnlcrdv-pinentry-1.1.0...
postPatchMkspecs
postMoveQtStaticLibs
/nix/store/fxik908q98gabnd2lx5krl7xn290nqdb-pinentry-1.1.0
/nix/store/nlxqjrf3swwwa1wwdwnvcdlqbry0kz88-pinentry-1.1.0
/nix/store/b6fsnc3v2hjf3kfjlb9cc4nfcnqxgsci-pinentry-1.1.0
/nix/store/94bcjm7vnlyqp9136dvjr2ayw5972cs5-pinentry-1.1.0
/nix/store/x3fiiwsqbwxfdj5r3iz0r18shcnlcrdv-pinentry-1.1.0
orivej
reviewed
Dec 16, 2017
nixos/modules/config/no-x-libs.nix
Outdated
| @@ -35,7 +35,7 @@ with lib; | |||
| networkmanager_pptp = pkgs.networkmanager_pptp.override { withGnome = false; }; | |||
| networkmanager_vpnc = pkgs.networkmanager_vpnc.override { withGnome = false; }; | |||
| networkmanager_iodine = pkgs.networkmanager_iodine.override { withGnome = false; }; | |||
| pinentry = pkgs.pinentry.override { gtk2 = null; qt4 = null; }; | |||
| pinentry = pkgs.pinentry.override { gtk2 = null; }; | |||
There was a problem hiding this comment.
Just set pinentry = pkgs.pinentry_ncurses.
There was a problem hiding this comment.
Won’t that be infinite recursion?
Edit: Indeed
while evaluating the attribute ‘pinentry_ncurses’ at /home/jtojnar/Projects/nixpkgs/pkgs/top-level/all-packages.nix:3982:3:
infinite recursion encountered, at /home/jtojnar/Projects/nixpkgs/pkgs/top-level/all-packages.nix:3982:22
There was a problem hiding this comment.
Right, I'd define pinentry as an override of pinentry_ncurses in all-packages.nix to solve it.
orivej
approved these changes
Dec 16, 2017
There was a problem hiding this comment.
Failure for system: x86_64-darwin
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
(use '--show-trace' to show detailed location information)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/gpg/pinentry/blob/pinentry-1.1.0/NEWS#L1-L19
Things done
I ran pinentry binary from each of the package end tested
GETPINcommand.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)