Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP! dropbox: fix IOError #32726

Closed
wants to merge 1 commit into from
Closed

WIP! dropbox: fix IOError #32726

wants to merge 1 commit into from

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Fixes uncaught exception that terminated dropbox:

IOError: zipimport: can not open file ~/.dropbox-dist/dropbox-lnx.x86_64-40.4.46/python-packages-27.zip

Added zip packages to targetPkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Gerschtli
dropbox: fix IOError
fcaad41 
Fixes uncaught exception that terminated dropbox:
IOError: zipimport: can not open file
~/.dropbox-dist/dropbox-lnx.x86_64-40.4.46/python-packages-27.zip
@Mic92
Copy link
Member

Mic92 commented Dec 16, 2017 •
edited

Does dropbox call really the zip command? zipimport itself seems to implement the zip format on its own rather then shell out. I assume zlib or so is missing somewhere.

orivej
orivej reviewed Dec 16, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second though, at least one of zip and unzip should be unnecessary to fix the error, and it is not unlikely that both are not necessary.

@Gerschtli
Copy link
Contributor Author

As I see right now, I can't reproduce the error, therefore I can't test if my fix would actually work. I'm sorry, I try to figure out how to consistently reproduce the error

@Gerschtli
Copy link
Contributor Author

Related issue #31929

@Gerschtli Gerschtli changed the title dropbox: fix IOError WIP! dropbox: fix IOError Dec 16, 2017
@orivej
Copy link
Contributor

orivej commented Dec 16, 2017

Thanks for the reference I'm certain this PR will not help, let's not keep it open.

@orivej orivej closed this Dec 16, 2017
@Gerschtli Gerschtli deleted the fix/dropbox branch April 12, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gerschtli @Mic92 @orivej @GrahamcOfBorg