Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ROCK kernel which is required by AMDs ROCm project #32376

Closed
wants to merge 2 commits into from
Closed

Added ROCK kernel which is required by AMDs ROCm project #32376

wants to merge 2 commits into from

Conversation

alexanderkjeldaas
Copy link
Contributor

Make the ROCm OpenCL and ecosystem work.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@alexanderkjeldaas alexanderkjeldaas mentioned this pull request Dec 6, 2017
Open
Mic92
Mic92 reviewed Dec 6, 2017
View reviewed changes
pkgs/os-specific/linux/kernel/linux-4.11-kfd.nix
owner = "RadeonOpenCompute";
repo = "ROCK-Kernel-Driver";
# url = "https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver.git";
rev = "roc-1.6.x";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a branch, can you use a tag instead? Otherwise the source hash will break.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest tag is for 1.5 it seems, perhaps that is too old? In that case, using the commit id might be a little better than just the branch, until a tag is created.

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @Mic92's comment

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 26, 2018

This is outdated now.
@alexanderkjeldaas feel free to come up with a new PR if you still want to bring ROCK kernels to nixpkgs.
There is releases based on kernel 4.14 and 4.15 now it seems.

@c0bw3b c0bw3b closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@Mic92 Mic92 Mic92 left review comments

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alexanderkjeldaas @c0bw3b @matthewbauer @joachifm @Mic92 @GrahamcOfBorg